Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: Source/core/html/canvas/WebGLActiveInfo.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 #define WebGLActiveInfo_h 27 #define WebGLActiveInfo_h
28 28
29 #include "bindings/core/v8/ScriptWrappable.h" 29 #include "bindings/core/v8/ScriptWrappable.h"
30 #include "platform/graphics/GraphicsTypes3D.h" 30 #include "platform/graphics/GraphicsTypes3D.h"
31 #include "wtf/PassRefPtr.h" 31 #include "wtf/PassRefPtr.h"
32 #include "wtf/RefCounted.h" 32 #include "wtf/RefCounted.h"
33 #include "wtf/text/WTFString.h" 33 #include "wtf/text/WTFString.h"
34 34
35 namespace WebCore { 35 namespace WebCore {
36 36
37 class WebGLActiveInfo : public RefCounted<WebGLActiveInfo>, public ScriptWrappab le { 37 class WebGLActiveInfo FINAL : public RefCountedWillBeGarbageCollectedFinalized<W ebGLActiveInfo>, public ScriptWrappable {
bajones 2014/07/18 20:31:29 This doesn't need to be Finalized, does it?
sof 2014/07/18 21:39:29 String gets in the way of that; it having a RefPtr
38 public: 38 public:
39 static PassRefPtr<WebGLActiveInfo> create(const String& name, GLenum type, G Lint size) 39 static PassRefPtrWillBeRawPtr<WebGLActiveInfo> create(const String& name, GL enum type, GLint size)
40 { 40 {
41 return adoptRef(new WebGLActiveInfo(name, type, size)); 41 return adoptRefWillBeNoop(new WebGLActiveInfo(name, type, size));
42 } 42 }
43 String name() const { return m_name; } 43 String name() const { return m_name; }
44 GLenum type() const { return m_type; } 44 GLenum type() const { return m_type; }
45 GLint size() const { return m_size; } 45 GLint size() const { return m_size; }
46 46
47 void trace(Visitor*) { }
48
47 private: 49 private:
48 WebGLActiveInfo(const String& name, GLenum type, GLint size) 50 WebGLActiveInfo(const String& name, GLenum type, GLint size)
49 : m_name(name) 51 : m_name(name)
50 , m_type(type) 52 , m_type(type)
51 , m_size(size) 53 , m_size(size)
52 { 54 {
53 ASSERT(name.length()); 55 ASSERT(name.length());
54 ASSERT(type); 56 ASSERT(type);
55 ASSERT(size); 57 ASSERT(size);
56 ScriptWrappable::init(this); 58 ScriptWrappable::init(this);
57 } 59 }
58 String m_name; 60 String m_name;
59 GLenum m_type; 61 GLenum m_type;
60 GLint m_size; 62 GLint m_size;
61 }; 63 };
62 64
63 } 65 }
64 66
65 #endif // WebGLActiveInfo_h 67 #endif // WebGLActiveInfo_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698