Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: Source/core/html/canvas/WebGLUniformLocation.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Google Inc. All rights reserved. 3 * Copyright (C) 2009 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 16 matching lines...) Expand all
27 #ifndef WebGLUniformLocation_h 27 #ifndef WebGLUniformLocation_h
28 #define WebGLUniformLocation_h 28 #define WebGLUniformLocation_h
29 29
30 #include "bindings/core/v8/ScriptWrappable.h" 30 #include "bindings/core/v8/ScriptWrappable.h"
31 #include "core/html/canvas/WebGLProgram.h" 31 #include "core/html/canvas/WebGLProgram.h"
32 #include "wtf/PassRefPtr.h" 32 #include "wtf/PassRefPtr.h"
33 #include "wtf/RefCounted.h" 33 #include "wtf/RefCounted.h"
34 34
35 namespace WebCore { 35 namespace WebCore {
36 36
37 class WebGLUniformLocation FINAL : public RefCounted<WebGLUniformLocation>, publ ic ScriptWrappable { 37 class WebGLUniformLocation FINAL : public RefCountedWillBeGarbageCollectedFinali zed<WebGLUniformLocation>, public ScriptWrappable {
bajones 2014/07/18 20:31:29 This also looks like it doesn't need Finalization
sof 2014/07/18 21:39:29 Indeed so, it doesn't need finalization. Thanks, w
sof 2014/07/19 19:55:57 Done.
38 public: 38 public:
39 static PassRefPtr<WebGLUniformLocation> create(WebGLProgram*, GLint location ); 39 static PassRefPtrWillBeRawPtr<WebGLUniformLocation> create(WebGLProgram*, GL int location);
40 40
41 WebGLProgram* program() const; 41 WebGLProgram* program() const;
42 42
43 GLint location() const; 43 GLint location() const;
44 44
45 void trace(Visitor*);
46
45 protected: 47 protected:
46 WebGLUniformLocation(WebGLProgram*, GLint location); 48 WebGLUniformLocation(WebGLProgram*, GLint location);
47 49
48 private: 50 private:
49 RefPtr<WebGLProgram> m_program; 51 RefPtrWillBeMember<WebGLProgram> m_program;
50 GLint m_location; 52 GLint m_location;
51 unsigned m_linkCount; 53 unsigned m_linkCount;
52 }; 54 };
53 55
54 } // namespace WebCore 56 } // namespace WebCore
55 57
56 #endif // WebGLUniformLocation_h 58 #endif // WebGLUniformLocation_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698