Moves address_input_strings.grdp from chrome to third_party/libaddressinput

Moves address_input_strings.grdp from chrome to third_party/libaddressinput

BUG=672458
Review-Url: https://codereview.chromium.org/2886173002
Cr-Commit-Position: refs/heads/master@{#473183}
Committed: https://chromium.googlesource.com/chromium/src/+/55d390c3d615ea9ada49a2ee4dcc31acbd50ce12

[Moe, 2017-05-17 15:52:11]

mahmadi@chromium.org changed reviewers:
+ sdefresne@chromium.org

[Moe, 2017-05-17 15:52:12]

Hi Sylvain, Please take a look.

[sdefresne, 2017-05-17 16:08:12]

sdefresne@chromium.org changed reviewers:
+ mathp@chromium.org

[sdefresne, 2017-05-17 16:08:13]

LG though I would recommend moving the renumbering to a separate CL.

+mathp as OWNERS

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/resource...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/resource...
tools/gritsettings/resource_ids:301: "messages": [25300],
I'm not sure about renumbering all those resources. Maybe we can keep
address_input_strings.grd at 400, and land the renumbering in a followup CL. The
.grd file have the option to force an IDS/IDR index, so renumbering may cause
subtle issues. I also think the range for ids is limited to be below 31000.

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/translat...
File tools/gritsettings/translation_expectations.pyl (right):

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/translat...
tools/gritsettings/translation_expectations.pyl:25:
"third_party/libaddressinput/address_input_strings.grd",
sort

[Mathieu, 2017-05-17 16:28:16]

Few comments. How did you test that this works?

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
File third_party/libaddressinput/address_input_strings.grd (right):

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
third_party/libaddressinput/address_input_strings.grd:1: <?xml version="1.0"
encoding="utf-8"?>
I think I would prefer if this file was in third_party/libaddressinput/chromium/

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
third_party/libaddressinput/address_input_strings.grd:11:
third_party/libaddressinput/libaddressinput.gyp.
I think this is more like BUILD.gn now?

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
File third_party/libaddressinput/resources/address_input_strings_am.xtb (right):

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
third_party/libaddressinput/resources/address_input_strings_am.xtb:1: <?xml
version="1.0" ?>
I would put the resources under chromium/resources

(the reason is that everything under chromium/ is in the chromium repo and
everything under src is in the libaddressinput repo. It's a nice separation)

[Moe, 2017-05-17 17:37:45]

I tested this works by logging the strings in address_input_strings.grdp

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
File third_party/libaddressinput/address_input_strings.grd (right):

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
third_party/libaddressinput/address_input_strings.grd:1: <?xml version="1.0"
encoding="utf-8"?>
On 2017/05/17 16:28:16, Mathieu wrote:
> I think I would prefer if this file was in
third_party/libaddressinput/chromium/

Done.

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
third_party/libaddressinput/address_input_strings.grd:11:
third_party/libaddressinput/libaddressinput.gyp.
On 2017/05/17 16:28:16, Mathieu wrote:
> I think this is more like BUILD.gn now?

Done.

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
File third_party/libaddressinput/resources/address_input_strings_am.xtb (right):

https://codereview.chromium.org/2886173002/diff/1/third_party/libaddressinput...
third_party/libaddressinput/resources/address_input_strings_am.xtb:1: <?xml
version="1.0" ?>
On 2017/05/17 16:28:16, Mathieu wrote:
> I would put the resources under chromium/resources
> 
> (the reason is that everything under chromium/ is in the chromium repo and
> everything under src is in the libaddressinput repo. It's a nice separation)

Done.

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/resource...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/resource...
tools/gritsettings/resource_ids:301: "messages": [25300],
On 2017/05/17 16:08:13, sdefresne wrote:
> I'm not sure about renumbering all those resources. Maybe we can keep
> address_input_strings.grd at 400, and land the renumbering in a followup CL.
The
> .grd file have the option to force an IDS/IDR index, so renumbering may cause
> subtle issues. I also think the range for ids is limited to be below 31000.

Done.

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/translat...
File tools/gritsettings/translation_expectations.pyl (right):

https://codereview.chromium.org/2886173002/diff/1/tools/gritsettings/translat...
tools/gritsettings/translation_expectations.pyl:25:
"third_party/libaddressinput/address_input_strings.grd",
On 2017/05/17 16:08:13, sdefresne OOO till 22-05-2017 wrote:
> sort

Done.

[Mathieu, 2017-05-17 18:07:15]

lgtm

[Moe, 2017-05-17 18:46:36]

Patchset #3 (id:40001) has been deleted

[Moe, 2017-05-17 18:47:47]

mahmadi@chromium.org changed reviewers:
+ thestig@chromium.org
- sdefresne@chromium.org

[Moe, 2017-05-17 18:47:48]

Hi Lei, PTAL.

[Lei Zhang, 2017-05-17 19:02:15]

lgtm

Please update the CL. We are not moving the ios/ section around and there's no
need to add "signed off by".

https://codereview.chromium.org/2886173002/diff/60001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/2886173002/diff/60001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:358: # TODO(crbug.com/672458): Move to the
appropriate section.
You mean, move this up to around line ~300? Don't worry too much about it. I can
take care of that and cloud_print above together later.

If that's all there is left in the TODO, just call it done.

[Moe, 2017-05-17 19:19:42]

Description was changed from

==========
Moves address_input_strings.grdp from chrome to third_party/libaddressinput

Signed-off-by: Mohamad Ahmadi <mahmadi@chromium.org>

Increment ios strings ids to avoid conflict with address_input_strings.grd

BUG=672458
==========

to

==========
Moves address_input_strings.grdp from chrome to third_party/libaddressinput

BUG=672458
==========

[Moe, 2017-05-17 20:22:48]

Thank you.

https://codereview.chromium.org/2886173002/diff/60001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/2886173002/diff/60001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:358: # TODO(crbug.com/672458): Move to the
appropriate section.
On 2017/05/17 19:02:14, Lei Zhang wrote:
> You mean, move this up to around line ~300? Don't worry too much about it. I
can
> take care of that and cloud_print above together later.
> 
> If that's all there is left in the TODO, just call it done.

Done.

[Moe, 2017-05-18 16:23:23]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-05-18 16:23:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2886173002/#ps80001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-05-18 16:24:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 21:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 21:50:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Moe, 2017-05-19 12:22:51]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2017-05-19 12:23:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 14:42:50]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495196571151970,
"parent_rev": "b7060318b0cc8ccf7f4572104d08580919f1a733", "commit_rev":
"55d390c3d615ea9ada49a2ee4dcc31acbd50ce12"}

[commit-bot: I haz the power, 2017-05-19 14:43:10]

Description was changed from

==========
Moves address_input_strings.grdp from chrome to third_party/libaddressinput

BUG=672458
==========

to

==========
Moves address_input_strings.grdp from chrome to third_party/libaddressinput

BUG=672458

Review-Url: https://codereview.chromium.org/2886173002
Cr-Commit-Position: refs/heads/master@{#473183}
Committed:
https://chromium.googlesource.com/chromium/src/+/55d390c3d615ea9ada49a2ee4dcc...
==========

[commit-bot: I haz the power, 2017-05-19 14:43:12]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/55d390c3d615ea9ada49a2ee4dcc...