Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2891793002:
Adjust address_input_strings.grd string ids to avoid conflict with ios string ids. (Closed)
DescriptionAdjust address_input_strings.grd string ids to avoid conflict with ios string ids.
This allows address_input_strings.grd strings to be packed and used in chrome on iOS
Review-Url: https://codereview.chromium.org/2891793002
Cr-Commit-Position: refs/heads/master@{#472607}
Committed: https://chromium.googlesource.com/chromium/src/+/40647e5a14a43404a4ba75dd24fa968dd52188a8
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressed comments #
Total comments: 2
Patch Set 3 : Addressed comment #
Dependent Patchsets: Messages
Total messages: 24 (10 generated)
Description was changed from ========== Increment ios strings ids to avoid conflict with address_input_strings.grd ========== to ========== Increment ios strings ids to avoid conflict with address_input_strings.grd This allows address_input_strings.grd strings to be packed and used in chrome on iOS ==========
mahmadi@chromium.org changed reviewers: + sdefresne@chromium.org
Hi Sylvain, Please take a look.
https://codereview.chromium.org/2891793002/diff/1/tools/gritsettings/resource... File tools/gritsettings/resource_ids (right): https://codereview.chromium.org/2891793002/diff/1/tools/gritsettings/resource... tools/gritsettings/resource_ids:243: "includes": [20100], Please leave this one untouched (it should start at the same id as content/). https://codereview.chromium.org/2891793002/diff/1/tools/gritsettings/resource... tools/gritsettings/resource_ids:246: "includes": [22100], ditto.
lgtm to unblock you once you have reverted the ios/web and ios/web test entries
thanks. https://codereview.chromium.org/2891793002/diff/1/tools/gritsettings/resource... File tools/gritsettings/resource_ids (right): https://codereview.chromium.org/2891793002/diff/1/tools/gritsettings/resource... tools/gritsettings/resource_ids:243: "includes": [20100], On 2017/05/17 15:53:31, sdefresne wrote: > Please leave this one untouched (it should start at the same id as content/). Done. https://codereview.chromium.org/2891793002/diff/1/tools/gritsettings/resource... tools/gritsettings/resource_ids:246: "includes": [22100], On 2017/05/17 15:53:31, sdefresne wrote: > ditto. Done.
mahmadi@chromium.org changed reviewers: + thestig@chromium.org
+thestig@ for owners review.
https://codereview.chromium.org/2891793002/diff/20001/tools/gritsettings/reso... File tools/gritsettings/resource_ids (right): https://codereview.chromium.org/2891793002/diff/20001/tools/gritsettings/reso... tools/gritsettings/resource_ids:34: "chrome/app/address_input_strings.grd": { How about we move this down to the end of the file and let it start at id 28700? Then shift chromium_strings.grd and generated_resources.grd up by 100 here, instead of shifting the ios values down by 100.
https://codereview.chromium.org/2891793002/diff/20001/tools/gritsettings/reso... File tools/gritsettings/resource_ids (right): https://codereview.chromium.org/2891793002/diff/20001/tools/gritsettings/reso... tools/gritsettings/resource_ids:34: "chrome/app/address_input_strings.grd": { On 2017/05/17 18:11:46, Lei Zhang wrote: > How about we move this down to the end of the file and let it start at id 28700? > > Then shift chromium_strings.grd and generated_resources.grd up by 100 here, > instead of shifting the ios values down by 100. Done.
lgtm
CL description is slightly out of date with patch set 3 now.
Description was changed from ========== Increment ios strings ids to avoid conflict with address_input_strings.grd This allows address_input_strings.grd strings to be packed and used in chrome on iOS ========== to ========== Adjust address_input_strings.grd string ids to avoid conflict with ios string ids. This allows address_input_strings.grd strings to be packed and used in chrome on iOS ==========
Done. Thank you.
The CQ bit was checked by mahmadi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2891793002/#ps40001 (title: "Addressed comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495064928952330,
"parent_rev": "6f3598e45c88e71ece4efc04e044aa1759c82cf9", "commit_rev":
"40647e5a14a43404a4ba75dd24fa968dd52188a8"}
Message was sent while issue was closed.
Description was changed from ========== Adjust address_input_strings.grd string ids to avoid conflict with ios string ids. This allows address_input_strings.grd strings to be packed and used in chrome on iOS ========== to ========== Adjust address_input_strings.grd string ids to avoid conflict with ios string ids. This allows address_input_strings.grd strings to be packed and used in chrome on iOS Review-Url: https://codereview.chromium.org/2891793002 Cr-Commit-Position: refs/heads/master@{#472607} Committed: https://chromium.googlesource.com/chromium/src/+/40647e5a14a43404a4ba75dd24fa... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/40647e5a14a43404a4ba75dd24fa... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
