Move geometry classes from core/platform/graphics to platform/geometry

Move geometry classes from core/platform/graphics to platform/geometry

Move the basic geometry classes; FloatPoint3D, FloatPoint, FloatQuad,
FloatRect, FloatSize, IntPoint, IntRectExtent, IntRect, IntSize,
LayoutBoxExtent, LayoutPoint, LayoutRect, and LayoutSize from
core/platform/graphics and into the new platform module.

Also move the support enums TextDirection and WritingMode needed by
BoxExtent as well as AffineTransform and TransformationMatrix as they
are needed by FloatPoint (through the SVGPoint typedef).

BUG=297477
R=abarth@chromium.org, pdr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158725

[pdr., 2013-10-01 23:21:26]

LGTM for the primary change here, but you'll need additional OWNERS.

https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
File Source/platform/geometry/FloatPoint.h (right):

https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
Source/platform/geometry/FloatPoint.h:146: // FIXME: These are only used by
SVGPoint and should probably move there
Mind filing a bug for this?

https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
File Source/platform/geometry/FloatRect.h (right):

https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
Source/platform/geometry/FloatRect.h:238: // Map rect r from srcRect to an
equivalent rect in destRect.
Please update the comment

https://codereview.chromium.org/25494003/diff/1/Source/platform/transforms/Af...
File Source/platform/transforms/AffineTransform.cpp (right):

https://codereview.chromium.org/25494003/diff/1/Source/platform/transforms/Af...
Source/platform/transforms/AffineTransform.cpp:350: static inline SkScalar
WebCoreDoubleToSkScalar(double d)
Code duplication :(

[eae, 2013-10-01 23:23:52]

On 2013/10/01 23:21:26, pdr wrote:
> LGTM for the primary change here, but you'll need additional OWNERS.
> 
>
https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
> File Source/platform/geometry/FloatPoint.h (right):
> 
>
https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
> Source/platform/geometry/FloatPoint.h:146: // FIXME: These are only used by
> SVGPoint and should probably move there
> Mind filing a bug for this?

Will do.

> 
>
https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
> File Source/platform/geometry/FloatRect.h (right):
> 
>
https://codereview.chromium.org/25494003/diff/1/Source/platform/geometry/Floa...
> Source/platform/geometry/FloatRect.h:238: // Map rect r from srcRect to an
> equivalent rect in destRect.
> Please update the comment
> 
>
https://codereview.chromium.org/25494003/diff/1/Source/platform/transforms/Af...
> File Source/platform/transforms/AffineTransform.cpp (right):
> 
>
https://codereview.chromium.org/25494003/diff/1/Source/platform/transforms/Af...
> Source/platform/transforms/AffineTransform.cpp:350: static inline SkScalar
> WebCoreDoubleToSkScalar(double d)
> Code duplication :(

Yeah, felt silly to add a new file just to share a one-line conversion method.

[abarth-chromium, 2013-10-02 06:14:04]

LGTM2

@eae: In a separate CL, would you be willing to seed an OWNERS file for platform
based on who has been changing / reviewing changes to core/platform recently?

[abarth-chromium, 2013-10-02 06:23:03]

On 2013/10/02 06:14:04, abarth wrote:
> @eae: In a separate CL, would you be willing to seed an OWNERS file for
platform
> based on who has been changing / reviewing changes to core/platform recently?

Looks like tkent posted a CL for that:
https://codereview.chromium.org/25660002/.  I'd be interested in your thoughts
on that CL.

[eae, 2013-10-02 15:17:09]

Committed patchset #4 manually as r158725.