Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, David Black, donnd+watch_chromium.org, sadrul, zea+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, dcheng, rginda+watch_chromium.org, skanuj+watch_chromium.org, noyau+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, grt+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, tapted, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, kalyank, Jered, michaelpg+watch-options_chromium.org, tfarina, maxbogue+watch_chromium.org, plaree+watch_chromium.org, davemoore+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from Browser::CreateParams R=sky@chromium.org BUG=558054 Committed: https://crrev.com/85194900a247b6e4239560841ae77824297a4b3a Cr-Commit-Position: refs/heads/master@{#374431}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : mac cros #

Patch Set 5 : unused var #

Patch Set 6 : dcheck #

Total comments: 2

Patch Set 7 : remove desktop_type_ in bookmark_bubble_sign_in_delegate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -647 lines) Patch
M chrome/browser/app_controller_mac.mm View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_webusb_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_intent_helper_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/open_with_browser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/mobile_config_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_commands.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/download/notification/download_item_notification.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 3 4 5 6 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 2 3 4 5 6 4 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/sdch_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/power/process_power_collector_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/prefetch/prefetch_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_actions_desktop.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 7 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/sessions/session_restore.h View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 3 4 5 11 chunks +11 lines, -27 lines 0 comments Download
M chrome/browser/sessions/session_restore_android.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 7 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest_chromeos.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc View 1 2 3 4 5 6 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 6 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 3 chunks +9 lines, -18 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 13 chunks +15 lines, -26 lines 0 comments Download
M chrome/browser/ui/browser_close_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 11 chunks +21 lines, -36 lines 0 comments Download
M chrome/browser/ui/browser_finder_chromeos_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_live_tab_context.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_mac.cc View 1 chunk +10 lines, -29 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 5 chunks +9 lines, -18 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 5 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/scoped_tabbed_browser_displayer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/scoped_tabbed_browser_displayer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_focus_uitest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 1 2 3 4 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/login_ui_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 10 chunks +16 lines, -28 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/test/base/in_process_browser_test_mac.cc View 1 2 3 5 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
scottmg
4 years, 10 months ago (2016-02-05 22:54:30 UTC) #1
sky
LGTM https://codereview.chromium.org/1662783002/diff/100001/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc File chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc (left): https://codereview.chromium.org/1662783002/diff/100001/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc#oldcode43 chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc:43: desktop_type_)); Can you remove the desktop_type_ member?
4 years, 10 months ago (2016-02-08 17:28:05 UTC) #2
scottmg
https://codereview.chromium.org/1662783002/diff/100001/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc File chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc (left): https://codereview.chromium.org/1662783002/diff/100001/chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc#oldcode43 chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc:43: desktop_type_)); On 2016/02/08 17:28:05, sky wrote: > Can you ...
4 years, 10 months ago (2016-02-09 18:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662783002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662783002/120001
4 years, 10 months ago (2016-02-09 19:03:58 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-02-09 20:09:53 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:11:18 UTC) #9
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/85194900a247b6e4239560841ae77824297a4b3a
Cr-Commit-Position: refs/heads/master@{#374431}

Powered by Google App Engine
This is Rietveld 408576698