chrome/browser/ui/find_bar/find_bar_host_browsertest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc ('k') | chrome/browser/ui/scoped_tabbed_browser_displayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

index 49eb884d225798de8075a796214049ae7f20f058..3616e43621ad6fc48de04710088ca4b9c561b169 100644

--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

@@ -1324,8 +1324,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_NoIncognitoPrepopulate) {

// Open a new incognito window and navigate to the same page.

Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();

Browser* incognito_browser =

- new Browser(Browser::CreateParams(incognito_profile,

- browser()->host_desktop_type()));

+ new Browser(Browser::CreateParams(incognito_profile));

content::WindowedNotificationObserver observer(

content::NOTIFICATION_LOAD_STOP,

content::NotificationService::AllSources());

@@ -1386,8 +1385,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, ActivateLinkNavigatesPage) {

}

IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FitWindow) {

- Browser::CreateParams params(Browser::TYPE_POPUP, browser()->profile(),

- browser()->host_desktop_type());

+ Browser::CreateParams params(Browser::TYPE_POPUP, browser()->profile());

params.initial_bounds = gfx::Rect(0, 0, 250, 500);

Browser* popup = new Browser(params);

content::WindowedNotificationObserver observer(