chrome/browser/extensions/api/tabs/tabs_test.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api_unittest.cc ('k') | chrome/browser/extensions/extension_context_menu_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_test.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc

index f4044d8eb037fc4f92e19cf56e63ae550b46a143..aa258bcb21bf6fe8c8fb9cbd12cac3697754f1f7 100644

--- a/chrome/browser/extensions/api/tabs/tabs_test.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_test.cc

@@ -164,8 +164,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, GetWindow) {

// Popup.

Browser* popup_browser = new Browser(

- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(),

- browser()->host_desktop_type()));

+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));

function = new WindowsGetFunction();

function->set_extension(extension.get());

result.reset(utils::ToDictionary(

@@ -641,8 +640,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DontCreateTabInClosingPopupWindow) {

// a new tab in it. Tab should not be opened in the popup window, but in a

// tabbed browser window.

Browser* popup_browser = new Browser(

- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(),

- browser()->host_desktop_type()));

+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));

int window_id = ExtensionTabUtil::GetWindowId(popup_browser);

chrome::CloseWindow(popup_browser);

@@ -910,11 +908,9 @@ Browser* ExtensionWindowLastFocusedTest::CreateBrowserWithEmptyTab(

Browser* new_browser;

if (as_popup)

new_browser = new Browser(

- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(),

- browser()->host_desktop_type()));

+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));

else

- new_browser = new Browser(Browser::CreateParams(

- browser()->profile(), browser()->host_desktop_type()));

+ new_browser = new Browser(Browser::CreateParams(browser()->profile()));

AddBlankTabAndShow(new_browser);

return new_browser;

}

@@ -1271,8 +1267,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, FilteredEvents) {

" \"minWidth\": 200, \"minHeight\": 200,"

" \"maxWidth\": 400, \"maxHeight\": 400}}");

- Browser* browser_window = new Browser(Browser::CreateParams(

- browser()->profile(), browser()->host_desktop_type()));

+ Browser* browser_window =

+ new Browser(Browser::CreateParams(browser()->profile()));

AddBlankTabAndShow(browser_window);

DevToolsWindow* devtools_window =