chrome/browser/safe_browsing/srt_fetcher_win.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/srt_fetcher_win.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_manager_unittest.cc ('k') | chrome/browser/sessions/better_session_restore_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/srt_fetcher_win.cc

diff --git a/chrome/browser/safe_browsing/srt_fetcher_win.cc b/chrome/browser/safe_browsing/srt_fetcher_win.cc

index 8a2ae577f36516aa9359cef933345876dfac6501..e90118ded69c578ca7c6a321a561451dc5ad63de 100644

--- a/chrome/browser/safe_browsing/srt_fetcher_win.cc

+++ b/chrome/browser/safe_browsing/srt_fetcher_win.cc

@@ -95,7 +95,6 @@ void DisplaySRTPrompt(const base::FilePath& download_path) {

// show the prompt this time and will wait until the next run of the

// reporter. We can't use other ways of finding a browser because we don't

// have a profile.

- chrome::HostDesktopType desktop_type = chrome::GetActiveDesktop();

Browser* browser = chrome::FindLastActive();

if (!browser)

return;

@@ -108,7 +107,7 @@ void DisplaySRTPrompt(const base::FilePath& download_path) {

if (browser->type() != Browser::TYPE_TABBED) {

browser = chrome::FindTabbedBrowser(profile, false);

if (!browser)

- browser = new Browser(Browser::CreateParams(profile, desktop_type));

+ browser = new Browser(Browser::CreateParams(profile));

}

GlobalErrorService* global_error_service =

GlobalErrorServiceFactory::GetForProfile(profile);