Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index c9b67e13c4753b5ec85f0417910520934f55f8e1..6577b22188773cac3b14e0da90d9058f238f969a 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -627,27 +627,21 @@ bool WindowsCreateFunction::RunSync() {
}
// Create a new BrowserWindow.
- chrome::HostDesktopType host_desktop_type = chrome::GetActiveDesktop();
if (create_panel)
window_type = Browser::TYPE_POPUP;
- Browser::CreateParams create_params(window_type, window_profile,
- host_desktop_type);
+ Browser::CreateParams create_params(window_type, window_profile);
if (extension_id.empty()) {
create_params.initial_bounds = window_bounds;
} else {
create_params = Browser::CreateParams::CreateForApp(
web_app::GenerateApplicationNameFromExtensionId(extension_id),
- false /* trusted_source */,
- window_bounds,
- window_profile,
- host_desktop_type);
+ false /* trusted_source */, window_bounds, window_profile);
}
create_params.initial_show_state = ui::SHOW_STATE_NORMAL;
if (create_data && create_data->state) {
create_params.initial_show_state =
ConvertToWindowShowState(create_data->state);
}
- create_params.host_desktop_type = chrome::GetActiveDesktop();
Browser* new_window = new Browser(create_params);
« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_apitest.cc ('k') | chrome/browser/extensions/api/tabs/tabs_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698