Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7262)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 10ef350e5281554201c3f0e3735527c1eada7454..2d7a3c61c55d2431afde0176e0a94e6f8bc40c2b 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -1113,10 +1113,7 @@ void DevToolsWindow::OpenInNewTab(const std::string& url) {
ui::PAGE_TRANSITION_LINK, false);
WebContents* inspected_web_contents = GetInspectedWebContents();
if (!inspected_web_contents || !inspected_web_contents->OpenURL(params)) {
- chrome::HostDesktopType host_desktop_type =
- browser_ ? browser_->host_desktop_type() : chrome::GetActiveDesktop();
-
- chrome::ScopedTabbedBrowserDisplayer displayer(profile_, host_desktop_type);
+ chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
chrome::AddSelectedTabWithURL(displayer.browser(), GURL(url),
ui::PAGE_TRANSITION_LINK);
}
@@ -1191,10 +1188,7 @@ void DevToolsWindow::CreateDevToolsBrowser() {
dev_tools_defaults->SetBoolean("always_on_top", false);
}
- browser_ = new Browser(Browser::CreateParams::CreateForDevTools(
- profile_,
- chrome::GetHostDesktopTypeForNativeView(
- main_web_contents_->GetNativeView())));
+ browser_ = new Browser(Browser::CreateParams::CreateForDevTools(profile_));
browser_->tab_strip_model()->AddWebContents(
main_web_contents_, -1, ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
TabStripModel::ADD_ACTIVE);
« no previous file with comments | « chrome/browser/chromeos/ui/mobile_config_ui.cc ('k') | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698