Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8770)

Unified Diff: chrome/browser/ui/webui/chrome_web_contents_handler.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_contents_handler.cc
diff --git a/chrome/browser/ui/webui/chrome_web_contents_handler.cc b/chrome/browser/ui/webui/chrome_web_contents_handler.cc
index 079fd0bc8094aa8e00eb4f5259b44432574c6ae1..7b0360dd1d38c1f38b4cfe8efa1deaba7623f120 100644
--- a/chrome/browser/ui/webui/chrome_web_contents_handler.cc
+++ b/chrome/browser/ui/webui/chrome_web_contents_handler.cc
@@ -38,18 +38,10 @@ WebContents* ChromeWebContentsHandler::OpenURLFromTab(
Profile* profile = Profile::FromBrowserContext(context);
- chrome::HostDesktopType desktop_type = chrome::HOST_DESKTOP_TYPE_NATIVE;
- if (source) {
- Browser* source_browser = chrome::FindBrowserWithWebContents(source);
- if (source_browser)
- desktop_type = source_browser->host_desktop_type();
- }
-
Browser* browser = chrome::FindTabbedBrowser(profile, false);
const bool browser_created = !browser;
if (!browser)
- browser = new Browser(
- Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
+ browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
chrome::NavigateParams nav_params(browser, params.url, params.transition);
nav_params.referrer = params.referrer;
if (source && source->IsCrashed() &&
@@ -88,18 +80,10 @@ void ChromeWebContentsHandler::AddNewContents(
Profile* profile = Profile::FromBrowserContext(context);
- chrome::HostDesktopType desktop_type = chrome::HOST_DESKTOP_TYPE_NATIVE;
- if (source) {
- Browser* source_browser = chrome::FindBrowserWithWebContents(source);
- if (source_browser)
- desktop_type = source_browser->host_desktop_type();
- }
-
Browser* browser = chrome::FindTabbedBrowser(profile, false);
const bool browser_created = !browser;
if (!browser)
- browser = new Browser(
- Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
+ browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
chrome::NavigateParams params(browser, new_contents);
params.source_contents = source;
params.disposition = disposition;

Powered by Google App Engine
This is Rietveld 408576698