chrome/browser/ui/views/frame/browser_view_browsertest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_install_dialog_view.cc ('k') | chrome/browser/ui/views/frame/browser_view_focus_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view_browsertest.cc

diff --git a/chrome/browser/ui/views/frame/browser_view_browsertest.cc b/chrome/browser/ui/views/frame/browser_view_browsertest.cc

index ccfab4519c6b78cc629898ae17286e8a32bafd85..9c638626a51bea9c22544197e8d3256137cb2b71 100644

--- a/chrome/browser/ui/views/frame/browser_view_browsertest.cc

+++ b/chrome/browser/ui/views/frame/browser_view_browsertest.cc

@@ -85,9 +85,7 @@ class TestWebContentsObserver : public content::WebContentsObserver {

// Additionally when one of the tabs is destroyed NotifyNavigationStateChanged()

// is invoked on the other.

IN_PROC_BROWSER_TEST_F(BrowserViewTest, CloseWithTabs) {

- Browser* browser2 =

- new Browser(Browser::CreateParams(browser()->profile(),

- browser()->host_desktop_type()));

+ Browser* browser2 = new Browser(Browser::CreateParams(browser()->profile()));

chrome::AddTabAt(browser2, GURL(), -1, true);

TestWebContentsObserver observer(

@@ -99,9 +97,7 @@ IN_PROC_BROWSER_TEST_F(BrowserViewTest, CloseWithTabs) {

// Same as CloseWithTabs, but activates the first tab, which is the first tab

// BrowserView will destroy.

IN_PROC_BROWSER_TEST_F(BrowserViewTest, CloseWithTabsStartWithActive) {

- Browser* browser2 =

- new Browser(Browser::CreateParams(browser()->profile(),

- browser()->host_desktop_type()));

+ Browser* browser2 = new Browser(Browser::CreateParams(browser()->profile()));

chrome::AddTabAt(browser2, GURL(), -1, true);

browser2->tab_strip_model()->ActivateTabAt(0, true);