chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/first_run/drive_first_run_controller.cc ('k') | chrome/browser/chromeos/login/signin/oauth2_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc

diff --git a/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc b/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc

index 4a47fcc99b2cc78665ce3465852188302be37cf4..ef227ed418a4f14d1b9c26a39c04e86f5f41e5ea 100644

--- a/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc

+++ b/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc

@@ -30,8 +30,8 @@ class GoodiesDisplayerBrowserTest : public InProcessBrowserTest {

Browser* CreateBrowserAndDisplayer(int delta_days) {

// Create a new browser and wait for completion.

ui_test_utils::BrowserAddedObserver browser_added_observer;

- Browser* browser = new Browser(Browser::CreateParams(

- ProfileManager::GetActiveUserProfile(), chrome::GetActiveDesktop()));

+ Browser* browser = new Browser(

+ Browser::CreateParams(ProfileManager::GetActiveUserProfile()));

browser_added_observer.WaitForSingleNewBrowser();

// Set up Goodies Displayer and set fake age of device.

@@ -109,8 +109,7 @@ IN_PROC_BROWSER_TEST_F(GoodiesDisplayerBrowserTest, DisplayGoodies) {

// Shouldn't show Goodies tab in incognito mode.

Browser* incognito_browser = new Browser(

- Browser::CreateParams(browser->profile()->GetOffTheRecordProfile(),

- chrome::GetActiveDesktop()));

+ Browser::CreateParams(browser->profile()->GetOffTheRecordProfile()));

ASSERT_EQ(2u, chrome::GetTotalBrowserCount());

AddBlankTabAndShow(incognito_browser);

ExpectTabCounts(incognito_browser, 1, 0);