chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

index 3273dfb1e273bad819082c22f54a5fc2428df20e..d6fbec0d8b6641ab6eeafc1d204cd781d78a6711 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

@@ -936,7 +936,7 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchMaximized) {

content::WindowedNotificationObserver open_observer(

chrome::NOTIFICATION_BROWSER_WINDOW_READY,

content::NotificationService::AllSources());

- chrome::NewEmptyWindow(browser()->profile(), chrome::HOST_DESKTOP_TYPE_ASH);

+ chrome::NewEmptyWindow(browser()->profile());

open_observer.Wait();

Browser* browser2 = content::Source<Browser>(open_observer.source()).ptr();

aura::Window* window2 = browser2->window()->GetNativeWindow();

@@ -1605,8 +1605,7 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ActivateAfterSessionRestore) {

ash::ShelfID shortcut_id = CreateShortcut("app1");

// Create a new browser - without activating it - and load an "app" into it.

- Browser::CreateParams params =

- Browser::CreateParams(profile(), chrome::GetActiveDesktop());

+ Browser::CreateParams params = Browser::CreateParams(profile());

params.initial_show_state = ui::SHOW_STATE_INACTIVE;

Browser* browser2 = new Browser(params);

controller_->SetRefocusURLPatternForTest(