chrome/browser/ui/views/frame/browser_view_focus_uitest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view_focus_uitest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_browsertest.cc ('k') | chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view_focus_uitest.cc

diff --git a/chrome/browser/ui/views/frame/browser_view_focus_uitest.cc b/chrome/browser/ui/views/frame/browser_view_focus_uitest.cc

index 3f5418e4fa607bf2853e1feacb7e4a1bf1234f20..9fbc0bcbdb549fa2b5e12794395b4316d9c44977 100644

--- a/chrome/browser/ui/views/frame/browser_view_focus_uitest.cc

+++ b/chrome/browser/ui/views/frame/browser_view_focus_uitest.cc

@@ -56,9 +56,7 @@ IN_PROC_BROWSER_TEST_F(BrowserViewFocusTest, DISABLED_BrowsersRememberFocus) {

// of Activate() is not well defined and can vary by window manager.

#if defined(OS_WIN)

// Open a new browser window.

- Browser* browser2 =

- new Browser(Browser::CreateParams(browser()->profile(),

- browser()->host_desktop_type()));

+ Browser* browser2 = new Browser(Browser::CreateParams(browser()->profile()));

ASSERT_TRUE(browser2);

chrome::AddTabAt(browser2, GURL(), -1, true);

browser2->window()->Show();