chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

index 63b1f27280ac40ef4fef393ceb4e5bc4e562a388..28bfc32ce2e95f54cfd282b26b600e113047139a 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

@@ -698,12 +698,9 @@ class V1App : public TestBrowserWindow {

aura::client::ParentWindowWithContext(native_window_.get(),

ash::Shell::GetPrimaryRootWindow(),

gfx::Rect(10, 10, 20, 30));

- Browser::CreateParams params =

- Browser::CreateParams::CreateForApp(kCrxAppPrefix + app_name,

- true /* trusted_source */,

- gfx::Rect(),

- profile,

- chrome::HOST_DESKTOP_TYPE_ASH);

+ Browser::CreateParams params = Browser::CreateParams::CreateForApp(

+ kCrxAppPrefix + app_name, true /* trusted_source */, gfx::Rect(),

+ profile);

params.window = this;

browser_.reset(new Browser(params));

chrome::AddTabAt(browser_.get(), GURL(), 0, true);

@@ -1542,7 +1539,7 @@ TEST_F(MultiProfileMultiBrowserShelfLayoutChromeLauncherControllerTest,

multi_user_util::GetAccountIdFromProfile(profile());

// Create a browser window with a native window for the current user.

- Browser::CreateParams params(profile(), chrome::HOST_DESKTOP_TYPE_ASH);

+ Browser::CreateParams params(profile());

scoped_ptr<Browser> browser(

chrome::CreateBrowserWithAuraTestWindowForParams(nullptr, &params));

BrowserWindow* browser_window = browser->window();