chrome/browser/ui/browser_finder_chromeos_unittest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_finder_chromeos_unittest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_finder_chromeos_unittest.cc

diff --git a/chrome/browser/ui/browser_finder_chromeos_unittest.cc b/chrome/browser/ui/browser_finder_chromeos_unittest.cc

index a88c152374c3a4d266619c74a9d414ab431705e4..f7485f481ab94d6bba1dba50ec127c92257f9a98 100644

--- a/chrome/browser/ui/browser_finder_chromeos_unittest.cc

+++ b/chrome/browser/ui/browser_finder_chromeos_unittest.cc

@@ -95,8 +95,7 @@ TEST_F(BrowserFinderChromeOSTest, IncognitoBrowserMatchTest) {

set_browser(nullptr);

// Create an incognito browser.

- Browser::CreateParams params(profile()->GetOffTheRecordProfile(),

- chrome::HOST_DESKTOP_TYPE_ASH);

+ Browser::CreateParams params(profile()->GetOffTheRecordProfile());

scoped_ptr<Browser> incognito_browser(

chrome::CreateBrowserWithAuraTestWindowForParams(nullptr, &params));

// Incognito windows are excluded in GetBrowserCount() because kMatchAll

@@ -109,8 +108,7 @@ TEST_F(BrowserFinderChromeOSTest, IncognitoBrowserMatchTest) {

TEST_F(BrowserFinderChromeOSTest, FindBrowserOwnedByAnotherProfile) {

set_browser(nullptr);

- Browser::CreateParams params(profile()->GetOriginalProfile(),

- chrome::HOST_DESKTOP_TYPE_ASH);

+ Browser::CreateParams params(profile()->GetOriginalProfile());

scoped_ptr<Browser> browser(

chrome::CreateBrowserWithAuraTestWindowForParams(nullptr, &params));

GetUserWindowManager()->SetWindowOwner(browser->window()->GetNativeWindow(),

« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/browser_focus_uitest.cc » ('j') | no next file with comments »