chrome/browser/ui/ash/window_positioner_unittest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/window_positioner_unittest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/system_tray_delegate_common.cc ('k') | chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/window_positioner_unittest.cc

diff --git a/chrome/browser/ui/ash/window_positioner_unittest.cc b/chrome/browser/ui/ash/window_positioner_unittest.cc

index 0ec615fc2bc865892d0ff72655e7071b1bd7e412..9da0bc8bfecf139173693e9760af73606838479d 100644

--- a/chrome/browser/ui/ash/window_positioner_unittest.cc

+++ b/chrome/browser/ui/ash/window_positioner_unittest.cc

@@ -68,14 +68,12 @@ void WindowPositionerTest::SetUp() {

dummy_popup->SetBounds(gfx::Rect(16, 32, 128, 256));

// Create a browser for the window.

- Browser::CreateParams window_params(&profile_,

- chrome::HOST_DESKTOP_TYPE_ASH);

+ Browser::CreateParams window_params(&profile_);

browser_ = chrome::CreateBrowserWithAuraTestWindowForParams(

std::move(dummy_window), &window_params);

// Creating a browser for the popup.

- Browser::CreateParams popup_params(Browser::TYPE_POPUP, &profile_,

- chrome::HOST_DESKTOP_TYPE_ASH);

+ Browser::CreateParams popup_params(Browser::TYPE_POPUP, &profile_);

browser_popup_ = chrome::CreateBrowserWithAuraTestWindowForParams(

std::move(dummy_popup), &popup_params);