chrome/browser/extensions/api/sessions/sessions_api.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc ('k') | chrome/browser/extensions/api/sessions/sessions_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_api.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc

index 173747072af39ea7efbb6b526331d9c90df99ed2..a570d88119ffbad9195816e7aa25e115b8f5c0b1 100644

--- a/chrome/browser/extensions/api/sessions/sessions_api.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc

@@ -568,10 +568,9 @@ bool SessionsRestoreFunction::RestoreForeignSession(const SessionId& session_id,

return false;

}

- chrome::HostDesktopType host_desktop_type = browser->host_desktop_type();

// Only restore one window at a time.

std::vector<Browser*> browsers = SessionRestore::RestoreForeignSessionWindows(

- GetProfile(), host_desktop_type, window, window + 1);

+ GetProfile(), window, window + 1);

// Will always create one browser because we only restore one window per call.

DCHECK_EQ(1u, browsers.size());

return SetResultRestoredWindow(ExtensionTabUtil::GetWindowId(browsers[0]));