chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/tabs/pinned_tab_service_unittest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

index 93169f6b7b32c0e128781ca4d15320eb885a53fd..7e5fa26a2fe19f9f7a5c80082c2febb56ca29768 100644

--- a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

@@ -500,7 +500,7 @@ TEST_F(BackFwdMenuModelTest, EscapeLabel) {

TEST_F(BackFwdMenuModelTest, FaviconLoadTest) {

ASSERT_TRUE(profile()->CreateHistoryService(true, false));

profile()->CreateFaviconService();

- Browser::CreateParams native_params(profile(), chrome::GetActiveDesktop());

+ Browser::CreateParams native_params(profile());

scoped_ptr<Browser> browser(

chrome::CreateBrowserWithTestWindowForParams(&native_params));

FaviconDelegate favicon_delegate;