Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7214)

Unified Diff: chrome/browser/sessions/session_restore_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/session_restore_browsertest.cc b/chrome/browser/sessions/session_restore_browsertest.cc
index 05869337c889969570810d3523146f3e5863a41e..a53647572c2f461cd06d90be1a148679c320764e 100644
--- a/chrome/browser/sessions/session_restore_browsertest.cc
+++ b/chrome/browser/sessions/session_restore_browsertest.cc
@@ -136,7 +136,7 @@ class SessionRestoreTest : public InProcessBrowserTest {
ui_test_utils::BrowserAddedObserver window_observer;
SessionRestoreTestHelper restore_observer;
if (url.is_empty()) {
- chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
+ chrome::NewEmptyWindow(profile);
} else {
chrome::NavigateParams params(profile,
url,
@@ -483,8 +483,7 @@ IN_PROC_BROWSER_TEST_F(SessionRestoreTest,
// Create a new popup.
Profile* profile = browser()->profile();
Browser* popup =
- new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile,
- browser()->host_desktop_type()));
+ new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile));
popup->window()->Show();
// Close the browser.
@@ -815,10 +814,8 @@ IN_PROC_BROWSER_TEST_F(SessionRestoreTest, RestoreForeignSession) {
session.push_back(static_cast<const sessions::SessionWindow*>(&window));
ui_test_utils::BrowserAddedObserver window_observer;
- std::vector<Browser*> browsers =
- SessionRestore::RestoreForeignSessionWindows(
- profile, browser()->host_desktop_type(), session.begin(),
- session.end());
+ std::vector<Browser*> browsers = SessionRestore::RestoreForeignSessionWindows(
+ profile, session.begin(), session.end());
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
ASSERT_TRUE(new_browser);
ASSERT_EQ(2u, active_browser_list_->size());
@@ -1265,7 +1262,6 @@ IN_PROC_BROWSER_TEST_F(SessionRestoreTest, RestorePinnedSelectedTab) {
// Restore the session again, clobbering the existing tab.
SessionRestore::RestoreSession(
profile, new_browser,
- new_browser->host_desktop_type(),
SessionRestore::CLOBBER_CURRENT_TAB | SessionRestore::SYNCHRONOUS,
std::vector<GURL>());
@@ -1324,7 +1320,6 @@ IN_PROC_BROWSER_TEST_F(SessionRestoreTest, ClobberRestoreTest) {
// Restore the session again, clobbering the existing tab.
SessionRestore::RestoreSession(
profile, new_browser,
- new_browser->host_desktop_type(),
SessionRestore::CLOBBER_CURRENT_TAB | SessionRestore::SYNCHRONOUS,
std::vector<GURL>());
@@ -1423,7 +1418,7 @@ IN_PROC_BROWSER_TEST_F(SmartSessionRestoreTest, PRE_CorrectLoadingOrder) {
// Create a new window, which should trigger session restore.
ui_test_utils::BrowserAddedObserver window_observer;
- chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
+ chrome::NewEmptyWindow(profile);
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
ASSERT_TRUE(new_browser);
WaitForAllTabsToStartLoading();
@@ -1467,7 +1462,7 @@ IN_PROC_BROWSER_TEST_F(SmartSessionRestoreTest, MAYBE_CorrectLoadingOrder) {
// Create a new window, which should trigger session restore.
ui_test_utils::BrowserAddedObserver window_observer;
- chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
+ chrome::NewEmptyWindow(profile);
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
ASSERT_TRUE(new_browser);
WaitForAllTabsToStartLoading();
« no previous file with comments | « chrome/browser/sessions/session_restore_android.cc ('k') | chrome/browser/sessions/session_restore_browsertest_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698