chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_browsertest.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index d7b4b7b3d6be52c3c9f9ce77cb5ad95ebe586015..c648526f531a2b60721f6d9099fbea73c75137f0 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -630,7 +630,7 @@ bool StartupBrowserCreatorImpl::ProcessStartupURLs(

// The startup code only executes for browsers launched in desktop mode.

// i.e. HOST_DESKTOP_TYPE_NATIVE. Ash should never get here.

Browser* browser = SessionRestore::RestoreSession(

- profile_, NULL, desktop_type, restore_behavior, adjusted_urls);

+ profile_, NULL, restore_behavior, adjusted_urls);

AddInfoBarsIfNecessary(browser, chrome::startup::IS_PROCESS_STARTUP);

return true;

@@ -744,7 +744,7 @@ Browser* StartupBrowserCreatorImpl::OpenTabsInBrowser(

profile_ = browser->profile();

if (!browser || !browser->is_type_tabbed())

- browser = new Browser(Browser::CreateParams(profile_, desktop_type));

+ browser = new Browser(Browser::CreateParams(profile_));

bool first_tab = true;

ProtocolHandlerRegistry* registry = profile_ ?