Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | chrome/test/base/in_process_browser_test_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/in_process_browser_test.cc
diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc
index 4980fdb69bd0a31bbcacf4c54b4b9ea8add3112b..0a01a5e17f5d699659ed36b0b881c97cfaee0ecb 100644
--- a/chrome/test/base/in_process_browser_test.cc
+++ b/chrome/test/base/in_process_browser_test.cc
@@ -429,8 +429,7 @@ void InProcessBrowserTest::OpenDevToolsWindow(
Browser* InProcessBrowserTest::OpenURLOffTheRecord(Profile* profile,
const GURL& url) {
- chrome::HostDesktopType active_desktop = chrome::GetActiveDesktop();
- chrome::OpenURLOffTheRecord(profile, url, active_desktop);
+ chrome::OpenURLOffTheRecord(profile, url);
Browser* browser =
chrome::FindTabbedBrowser(profile->GetOffTheRecordProfile(), false);
content::TestNavigationObserver observer(
@@ -442,8 +441,7 @@ Browser* InProcessBrowserTest::OpenURLOffTheRecord(Profile* profile,
// Creates a browser with a single tab (about:blank), waits for the tab to
// finish loading and shows the browser.
Browser* InProcessBrowserTest::CreateBrowser(Profile* profile) {
- Browser* browser = new Browser(
- Browser::CreateParams(profile, chrome::GetActiveDesktop()));
+ Browser* browser = new Browser(Browser::CreateParams(profile));
AddBlankTabAndShow(browser);
return browser;
}
@@ -451,16 +449,14 @@ Browser* InProcessBrowserTest::CreateBrowser(Profile* profile) {
Browser* InProcessBrowserTest::CreateIncognitoBrowser() {
// Create a new browser with using the incognito profile.
Browser* incognito = new Browser(
- Browser::CreateParams(browser()->profile()->GetOffTheRecordProfile(),
- chrome::GetActiveDesktop()));
+ Browser::CreateParams(browser()->profile()->GetOffTheRecordProfile()));
AddBlankTabAndShow(incognito);
return incognito;
}
Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) {
Browser* browser =
- new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile,
- chrome::GetActiveDesktop()));
+ new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile));
AddBlankTabAndShow(browser);
return browser;
}
@@ -470,8 +466,7 @@ Browser* InProcessBrowserTest::CreateBrowserForApp(
Profile* profile) {
Browser* browser = new Browser(
Browser::CreateParams::CreateForApp(
- app_name, false /* trusted_source */, gfx::Rect(), profile,
- chrome::GetActiveDesktop()));
+ app_name, false /* trusted_source */, gfx::Rect(), profile));
AddBlankTabAndShow(browser);
return browser;
}
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | chrome/test/base/in_process_browser_test_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698