chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

index 25e6e645f3f90ef94405a4d392bf3c028ee8bfee..8de12fd0b53a5756268e131a471dec9554712250 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm

@@ -202,7 +202,7 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {

ASSERT_EQ(7, [menu numberOfItems]);

// Create a browser and "show" it.

- Browser::CreateParams profile2_params(profile2, chrome::GetActiveDesktop());

+ Browser::CreateParams profile2_params(profile2);

scoped_ptr<Browser> p2_browser(

chrome::CreateBrowserWithTestWindowForParams(&profile2_params));

BrowserList::SetLastActive(p2_browser.get());

@@ -213,7 +213,7 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {

VerifyProfileNamedIsActive(@"Profile 2", __LINE__);

// Open a new browser and make sure it takes effect.

- Browser::CreateParams profile3_params(profile3, chrome::GetActiveDesktop());

+ Browser::CreateParams profile3_params(profile3);

scoped_ptr<Browser> p3_browser(

chrome::CreateBrowserWithTestWindowForParams(&profile3_params));

BrowserList::SetLastActive(p3_browser.get());

@@ -279,8 +279,7 @@ TEST_F(ProfileMenuControllerTest, SupervisedProfile) {

EXPECT_TRUE([controller() validateMenuItem:item]);

// Open a new browser for the supervised user and switch to it.

- Browser::CreateParams supervised_profile_params(

- supervised_profile, chrome::HOST_DESKTOP_TYPE_NATIVE);

+ Browser::CreateParams supervised_profile_params(supervised_profile);

scoped_ptr<Browser> supervised_browser(

chrome::CreateBrowserWithTestWindowForParams(&supervised_profile_params));

BrowserList::SetLastActive(supervised_browser.get());