chrome/browser/ui/webui/settings/people_handler.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/people_handler.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | chrome/browser/ui/webui/signin/login_ui_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/people_handler.cc

diff --git a/chrome/browser/ui/webui/settings/people_handler.cc b/chrome/browser/ui/webui/settings/people_handler.cc

index 17d45e950dff183dcf34a03ec675df4d6f197243..4b1ad69d0a45e1061c88e60fdc63e5f7007f050a 100644

--- a/chrome/browser/ui/webui/settings/people_handler.cc

+++ b/chrome/browser/ui/webui/settings/people_handler.cc

@@ -319,8 +319,8 @@ void PeopleHandler::DisplayGaiaLoginInNewTabOrWindow(

bool force_new_tab = false;

if (!browser) {

// Settings is not displayed in a browser window. Open a new window.

- browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile_,

- chrome::GetActiveDesktop()));

+ browser =

+ new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile_));

force_new_tab = true;

}