Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/sessions/better_session_restore_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_win.cc ('k') | chrome/browser/sessions/session_restore.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/better_session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/better_session_restore_browsertest.cc b/chrome/browser/sessions/better_session_restore_browsertest.cc
index 758d3c7229d3012c58b498581942d7a15b5ad4e9..1ff9ebf944a18e31e1cd6f255297f943088024c4 100644
--- a/chrome/browser/sessions/better_session_restore_browsertest.cc
+++ b/chrome/browser/sessions/better_session_restore_browsertest.cc
@@ -332,7 +332,7 @@ class BetterSessionRestoreTest : public InProcessBrowserTest {
// Create a new window, which should trigger session restore.
ui_test_utils::BrowserAddedObserver window_observer;
- chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
+ chrome::NewEmptyWindow(profile);
Browser* new_browser = window_observer.WaitForSingleNewBrowser();
chrome::DecrementKeepAliveCount();
@@ -486,10 +486,8 @@ IN_PROC_BROWSER_TEST_F(ContinueWhereILeftOffTest,
// Set the startup preference to "continue where I left off" and visit a page
// which stores a session cookie.
StoreDataWithPage("session_cookies.html");
- Browser* popup = new Browser(Browser::CreateParams(
- Browser::TYPE_POPUP,
- browser()->profile(),
- chrome::HOST_DESKTOP_TYPE_NATIVE));
+ Browser* popup = new Browser(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
popup->window()->Show();
Browser* new_browser = QuitBrowserAndRestore(browser(), false);
@@ -771,10 +769,8 @@ IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest, SessionCookiesBrowserClose) {
IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
SessionCookiesBrowserCloseWithPopupOpen) {
StoreDataWithPage("session_cookies.html");
- Browser* popup = new Browser(Browser::CreateParams(
- Browser::TYPE_POPUP,
- browser()->profile(),
- chrome::HOST_DESKTOP_TYPE_NATIVE));
+ Browser* popup = new Browser(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
popup->window()->Show();
Browser* new_browser = QuitBrowserAndRestore(browser(), false);
NavigateAndCheckStoredData(new_browser, "session_cookies.html");
@@ -785,10 +781,8 @@ IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
SessionCookiesBrowserClosePopupLast) {
StoreDataWithPage("session_cookies.html");
- Browser* popup = new Browser(Browser::CreateParams(
- Browser::TYPE_POPUP,
- browser()->profile(),
- chrome::HOST_DESKTOP_TYPE_NATIVE));
+ Browser* popup = new Browser(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
popup->window()->Show();
CloseBrowserSynchronously(browser());
Browser* new_browser = QuitBrowserAndRestore(popup, false);
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_win.cc ('k') | chrome/browser/sessions/session_restore.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698