chrome/browser/ui/extensions/application_launch.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm ('k') | chrome/browser/ui/extensions/extension_install_ui_default.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/application_launch.cc

diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc

index 986bf75a781e34f9e7a3428af1aa14d6e4099b57..13025c67ad71d1a50de52fb636fd802a2b2f821a 100644

--- a/chrome/browser/ui/extensions/application_launch.cc

+++ b/chrome/browser/ui/extensions/application_launch.cc

@@ -195,12 +195,8 @@ WebContents* OpenApplicationWindow(const AppLaunchParams& params,

extensions::AppLaunchInfo::GetLaunchHeight(extension));

}

- Browser::CreateParams browser_params(

- Browser::CreateParams::CreateForApp(app_name,

- true /* trusted_source */,

- initial_bounds,

- profile,

- params.desktop_type));

+ Browser::CreateParams browser_params(Browser::CreateParams::CreateForApp(

+ app_name, true /* trusted_source */, initial_bounds, profile));

browser_params.initial_show_state = DetermineWindowShowState(profile,

params.container,

@@ -235,9 +231,7 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,

WebContents* contents = NULL;

if (!browser) {

// No browser for this profile, need to open a new one.

- browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED,

- profile,

- launch_params.desktop_type));

+ browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));

browser->window()->Show();

// There's no current tab in this browser window, so add a new one.

disposition = NEW_FOREGROUND_TAB;