Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/ui/browser_mac.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12
Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser_live_tab_context.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_mac.h" 5 #include "chrome/browser/ui/browser_mac.h"
6 6
7 #include "chrome/browser/profiles/profile.h" 7 #include "chrome/browser/profiles/profile.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_window.h" 9 #include "chrome/browser/ui/browser_window.h"
10 #include "chrome/browser/ui/host_desktop.h" 10 #include "chrome/browser/ui/host_desktop.h"
11 11
12 namespace chrome { 12 namespace chrome {
13 13
14 void OpenAboutWindow(Profile* profile) { 14 void OpenAboutWindow(Profile* profile) {
15 Browser* browser = 15 Browser* browser = new Browser(Browser::CreateParams(profile));
16 new Browser(Browser::CreateParams(profile,
17 chrome::HOST_DESKTOP_TYPE_NATIVE));
18 ShowAboutChrome(browser); 16 ShowAboutChrome(browser);
19 browser->window()->Show(); 17 browser->window()->Show();
20 } 18 }
21 19
22 void OpenHistoryWindow(Profile* profile) { 20 void OpenHistoryWindow(Profile* profile) {
23 Browser* browser = 21 Browser* browser =
24 new Browser(Browser::CreateParams(profile, 22 new Browser(Browser::CreateParams(profile));
25 chrome::HOST_DESKTOP_TYPE_NATIVE));
26 ShowHistory(browser); 23 ShowHistory(browser);
27 browser->window()->Show(); 24 browser->window()->Show();
28 } 25 }
29 26
30 void OpenDownloadsWindow(Profile* profile) { 27 void OpenDownloadsWindow(Profile* profile) {
31 Browser* browser = 28 Browser* browser = new Browser(Browser::CreateParams(profile));
32 new Browser(Browser::CreateParams(profile,
33 chrome::HOST_DESKTOP_TYPE_NATIVE));
34 ShowDownloads(browser); 29 ShowDownloads(browser);
35 browser->window()->Show(); 30 browser->window()->Show();
36 } 31 }
37 32
38 void OpenHelpWindow(Profile* profile, HelpSource source) { 33 void OpenHelpWindow(Profile* profile, HelpSource source) {
39 Browser* browser = 34 Browser* browser = new Browser(Browser::CreateParams(profile));
40 new Browser(Browser::CreateParams(profile,
41 chrome::HOST_DESKTOP_TYPE_NATIVE));
42 ShowHelp(browser, source); 35 ShowHelp(browser, source);
43 browser->window()->Show(); 36 browser->window()->Show();
44 } 37 }
45 38
46 void OpenOptionsWindow(Profile* profile) { 39 void OpenOptionsWindow(Profile* profile) {
47 Browser* browser = 40 Browser* browser = new Browser(Browser::CreateParams(profile));
48 new Browser(Browser::CreateParams(profile,
49 chrome::HOST_DESKTOP_TYPE_NATIVE));
50 ShowSettings(browser); 41 ShowSettings(browser);
51 browser->window()->Show(); 42 browser->window()->Show();
52 } 43 }
53 44
54 void OpenSyncSetupWindow(Profile* profile, 45 void OpenSyncSetupWindow(Profile* profile,
55 signin_metrics::AccessPoint access_point) { 46 signin_metrics::AccessPoint access_point) {
56 Browser* browser = 47 Browser* browser = new Browser(Browser::CreateParams(profile));
57 new Browser(Browser::CreateParams(profile,
58 chrome::HOST_DESKTOP_TYPE_NATIVE));
59 ShowBrowserSigninOrSettings(browser, access_point); 48 ShowBrowserSigninOrSettings(browser, access_point);
60 browser->window()->Show(); 49 browser->window()->Show();
61 } 50 }
62 51
63 void OpenClearBrowsingDataDialogWindow(Profile* profile) { 52 void OpenClearBrowsingDataDialogWindow(Profile* profile) {
64 Browser* browser = 53 Browser* browser = new Browser(Browser::CreateParams(profile));
65 new Browser(Browser::CreateParams(profile,
66 chrome::HOST_DESKTOP_TYPE_NATIVE));
67 ShowClearBrowsingDataDialog(browser); 54 ShowClearBrowsingDataDialog(browser);
68 browser->window()->Show(); 55 browser->window()->Show();
69 } 56 }
70 57
71 void OpenImportSettingsDialogWindow(Profile* profile) { 58 void OpenImportSettingsDialogWindow(Profile* profile) {
72 Browser* browser = 59 Browser* browser = new Browser(Browser::CreateParams(profile));
73 new Browser(Browser::CreateParams(profile,
74 chrome::HOST_DESKTOP_TYPE_NATIVE));
75 ShowImportDialog(browser); 60 ShowImportDialog(browser);
76 browser->window()->Show(); 61 browser->window()->Show();
77 } 62 }
78 63
79 void OpenBookmarkManagerWindow(Profile* profile) { 64 void OpenBookmarkManagerWindow(Profile* profile) {
80 Browser* browser = 65 Browser* browser = new Browser(Browser::CreateParams(profile));
81 new Browser(Browser::CreateParams(profile,
82 chrome::HOST_DESKTOP_TYPE_NATIVE));
83 ShowBookmarkManager(browser); 66 ShowBookmarkManager(browser);
84 browser->window()->Show(); 67 browser->window()->Show();
85 } 68 }
86 69
87 void OpenExtensionsWindow(Profile* profile) { 70 void OpenExtensionsWindow(Profile* profile) {
88 Browser* browser = 71 Browser* browser = new Browser(Browser::CreateParams(profile));
89 new Browser(Browser::CreateParams(profile,
90 chrome::HOST_DESKTOP_TYPE_NATIVE));
91 ShowExtensions(browser, std::string()); 72 ShowExtensions(browser, std::string());
92 browser->window()->Show(); 73 browser->window()->Show();
93 } 74 }
94 75
95 } // namespace chrome 76 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_live_tab_context.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698