chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

diff --git a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

index 9ebd1fb35a4a847794ca09929746d3a7be9f92bb..3f4bdfd77b6e641dc5d870ce1a3752b06c5fa440 100644

--- a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

+++ b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm

@@ -25,12 +25,9 @@ IN_PROC_BROWSER_TEST_F(BrowserCrApplicationAppleScriptTest, Creation) {

// Create additional |Browser*| objects of different type.

Profile* profile = browser()->profile();

Browser* b1 =

- new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile,

- browser()->host_desktop_type()));

- Browser* b2 = new Browser(

- Browser::CreateParams::CreateForApp(

- "Test", true /* trusted_source */, gfx::Rect(), profile,

- browser()->host_desktop_type()));

+ new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile));

+ Browser* b2 = new Browser(Browser::CreateParams::CreateForApp(

+ "Test", true /* trusted_source */, gfx::Rect(), profile));

EXPECT_EQ(3U, [[NSApp appleScriptWindows] count]);

for (WindowAppleScript* window in [NSApp appleScriptWindows]) {

« no previous file with comments | « chrome/browser/ui/chrome_pages.cc ('k') | chrome/browser/ui/cocoa/applescript/window_applescript.mm » ('j') | no next file with comments »