chrome/browser/ui/startup/startup_browser_creator_browsertest.cc - Issue 1662783002: Remove HostDesktopType from Browser::CreateParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 1662783002: Remove HostDesktopType from Browser::CreateParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-12

Patch Set: remove desktop_type_ in bookmark_bubble_sign_in_delegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

index d08008a1e0bd0ff67cfa120ab9d2848ddabe602b..9affdd52f3a60d1a430e785fef89f68d2043e72a 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

@@ -233,8 +233,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenURLsPopup) {

BrowserList::AddObserver(&observer);

Browser* popup = new Browser(

- Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile(),

- browser()->host_desktop_type()));

+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));

ASSERT_TRUE(popup->is_type_popup());

ASSERT_EQ(popup, observer.added_browser_);

@@ -838,17 +837,15 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, PRE_UpdateWithTwoProfiles) {

ASSERT_TRUE(profile2);

// Open some urls with the browsers, and close them.

- Browser* browser1 = new Browser(

- Browser::CreateParams(Browser::TYPE_TABBED, profile1,

- browser()->host_desktop_type()));

+ Browser* browser1 =

+ new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile1));

chrome::NewTab(browser1);

ui_test_utils::NavigateToURL(browser1,

embedded_test_server()->GetURL("/empty.html"));

CloseBrowserSynchronously(browser1);

Browser* browser2 = new Browser(

- Browser::CreateParams(Browser::TYPE_TABBED, profile2,

- browser()->host_desktop_type()));

+ Browser::CreateParams(Browser::TYPE_TABBED, profile2));

chrome::NewTab(browser2);

ui_test_utils::NavigateToURL(browser2,

embedded_test_server()->GetURL("/form.html"));

@@ -992,8 +989,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest,

// Open a page with profile_last.

Browser* browser_last = new Browser(

- Browser::CreateParams(Browser::TYPE_TABBED, profile_last,

- browser()->host_desktop_type()));

+ Browser::CreateParams(Browser::TYPE_TABBED, profile_last));

chrome::NewTab(browser_last);

ui_test_utils::NavigateToURL(browser_last,

embedded_test_server()->GetURL("/empty.html"));