Fix classes that have too many virtuals for inline constructors.

Fix classes that have too many virtuals for inline constructors.

BUG=565523
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[Jeffrey Yasskin, 2015-12-04 03:37:13]

Description was changed from

==========
Fix classes that have too many virtuals for inline constructors.

BUG=565523
==========

to

==========
Fix classes that have too many virtuals for inline constructors.

BUG=565523
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tfarina, 2015-12-04 20:30:27]

no skia?

I'm getting ../../skia/config/sk_ref_cnt_ext_debug.h:17:3: error:
[chromium-style] Complex constructor has an inlined body.
  SkRefCnt() : flags_(0) {}

[Jeffrey Yasskin, 2015-12-04 21:05:38]

Yeah, the patch isn't complete yet.

On Fri, Dec 4, 2015 at 12:30 PM, <tfarina@chromium.org> wrote:

> no skia?
>
> I'm getting ../../skia/config/sk_ref_cnt_ext_debug.h:17:3: error:
> [chromium-style] Complex constructor has an inlined body.
>   SkRefCnt() : flags_(0) {}
>
> https://codereview.chromium.org/1499793003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jeffrey Yasskin, 2015-12-10 04:52:08]

Patchset #4 (id:60001) has been deleted

[Jeffrey Yasskin, 2015-12-10 04:52:18]

Patchset #4 (id:80001) has been deleted

[Jeffrey Yasskin, 2015-12-10 04:57:41]

jyasskin@chromium.org changed reviewers:
+ thakis@chromium.org

[Jeffrey Yasskin, 2015-12-10 04:57:41]

Here's a patch that fixes ninja-with-no-arguments on my linux box. There are
probably a couple more fixes needed for Mac, but I'm now confident the
clang-plugin patch has sensible results.

[danakj, 2015-12-10 19:35:57]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-12-10 19:35:58]

https://codereview.chromium.org/1499793003/diff/100001/cc/trees/property_tree.h
File cc/trees/property_tree.h (right):

https://codereview.chromium.org/1499793003/diff/100001/cc/trees/property_tree...
cc/trees/property_tree.h:462: ClipTree();
Can you explain why this change? The base class has a virtual function and a
virtual destructor, both out-of-line. What makes the rule require this out of
line constructor?

[Jeffrey Yasskin, 2015-12-10 20:28:59]

https://codereview.chromium.org/1499793003/diff/100001/cc/trees/property_tree.h
File cc/trees/property_tree.h (right):

https://codereview.chromium.org/1499793003/diff/100001/cc/trees/property_tree...
cc/trees/property_tree.h:462: ClipTree();
On 2015/12/10 19:35:58, danakj (behind on reviews) wrote:
> Can you explain why this change? The base class has a virtual function and a
> virtual destructor, both out-of-line. What makes the rule require this out of
> line constructor?

There's a templated base class, which gives an initial score of 9:
https://codereview.chromium.org/1493813003/diff/100001/tools/clang/plugins/Fi....
Then the vtable adds 3:
https://codereview.chromium.org/1493813003/diff/100001/tools/clang/plugins/Fi...,
which puts the whole leaf class over 10.

[danakj, 2015-12-10 21:02:19]

I see, thanks. Well cc/ LGTM :)

[danakj, 2016-03-14 20:37:59]

poke, what's next to do here?

[Jeffrey Yasskin, 2016-03-14 21:17:18]

On 2016/03/14 20:37:59, danakj wrote:
> poke, what's next to do here?

This is waiting on https://codereview.chromium.org/1493813003.