ash/shell_observer.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell_observer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell_observer.h

diff --git a/ash/shell_observer.h b/ash/shell_observer.h

index da53428ccba14f155988e533bdb7824cdc305563..76085a7e9640694eaa5f0601fc3a952f5d2a9440 100644

--- a/ash/shell_observer.h

+++ b/ash/shell_observer.h

@@ -67,6 +67,7 @@ class ASH_EXPORT ShellObserver {

virtual void OnShellInitialized() {}

protected:

+ ShellObserver() = default;

virtual ~ShellObserver() {}

};

« no previous file with comments | « no previous file | cc/test/fake_layer_tree_host_impl_client.h » ('j') | cc/trees/property_tree.h » ('J')