components/mus/ws/server_window_observer.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/mus/ws/server_window_observer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/trees/property_tree.h ('K') | « components/mus/public/cpp/window_observer.h ('k') | components/test_runner/mock_web_speech_recognizer.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_MUS_WS_SERVER_WINDOW_OBSERVER_H_	5 #ifndef COMPONENTS_MUS_WS_SERVER_WINDOW_OBSERVER_H_

6 #define COMPONENTS_MUS_WS_SERVER_WINDOW_OBSERVER_H_	6 #define COMPONENTS_MUS_WS_SERVER_WINDOW_OBSERVER_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "components/mus/public/interfaces/mus_constants.mojom.h"	10 #include "components/mus/public/interfaces/mus_constants.mojom.h"

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
72	72

73 // Called when a transient child is added to \|window\|.	73 // Called when a transient child is added to \|window\|.

74 virtual void OnTransientWindowAdded(ServerWindow* window,	74 virtual void OnTransientWindowAdded(ServerWindow* window,

75 ServerWindow* transient_child) {}	75 ServerWindow* transient_child) {}

76	76

77 // Called when a transient child is removed from \|window\|.	77 // Called when a transient child is removed from \|window\|.

78 virtual void OnTransientWindowRemoved(ServerWindow* window,	78 virtual void OnTransientWindowRemoved(ServerWindow* window,

79 ServerWindow* transient_child) {}	79 ServerWindow* transient_child) {}

80	80

81 protected:	81 protected:

	82 ServerWindowObserver() = default;

82 virtual ~ServerWindowObserver() {}	83 virtual ~ServerWindowObserver() {}

83 };	84 };

84	85

85 } // namespace ws	86 } // namespace ws

86	87

87 } // namespace mus	88 } // namespace mus

88	89

89 #endif // COMPONENTS_MUS_WS_SERVER_WINDOW_OBSERVER_H_	90 #endif // COMPONENTS_MUS_WS_SERVER_WINDOW_OBSERVER_H_

OLD	NEW