chrome/browser/chrome_browser_main_extra_parts.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main_extra_parts.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main_extra_parts.h

diff --git a/chrome/browser/chrome_browser_main_extra_parts.h b/chrome/browser/chrome_browser_main_extra_parts.h

index 4ab0e512d888804b6e883f19f7689b7a640b509a..83a94af44fa349a9b783ba80f8e4d22bd23e8b60 100644

--- a/chrome/browser/chrome_browser_main_extra_parts.h

+++ b/chrome/browser/chrome_browser_main_extra_parts.h

@@ -40,6 +40,9 @@ class ChromeBrowserMainExtraParts {

virtual void PostBrowserStart() {}

virtual void PreMainMessageLoopRun() {}

virtual void PostMainMessageLoopRun() {}

+ protected:

+ ChromeBrowserMainExtraParts() = default;

};

#endif // CHROME_BROWSER_CHROME_BROWSER_MAIN_EXTRA_PARTS_H_

« cc/trees/property_tree.h ('K') | « cc/trees/property_tree.cc ('k') | chrome/browser/chrome_content_browser_client_parts.h » ('j') | no next file with comments »