net/quic/test_tools/quic_test_utils.cc - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/quic_test_utils.cc

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/test_tools/quic_test_utils.cc

diff --git a/net/quic/test_tools/quic_test_utils.cc b/net/quic/test_tools/quic_test_utils.cc

index 7bb892fceeeb8d9512f355e600655d15c68a086d..0f89c42f60346c89659f0a5002bfd54d372e538d 100644

--- a/net/quic/test_tools/quic_test_utils.cc

+++ b/net/quic/test_tools/quic_test_utils.cc

@@ -142,6 +142,8 @@ MockFramerVisitor::MockFramerVisitor() {

MockFramerVisitor::~MockFramerVisitor() {}

+NoOpFramerVisitor::NoOpFramerVisitor() = default;

bool NoOpFramerVisitor::OnProtocolVersionMismatch(QuicVersion version) {

return false;

}

« cc/trees/property_tree.h ('K') | « net/quic/test_tools/quic_test_utils.h ('k') | net/tools/balsa/balsa_frame.h » ('j') | no next file with comments »