components/mus/public/cpp/window_observer.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/window_observer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/mus/public/cpp/window_observer.h

diff --git a/components/mus/public/cpp/window_observer.h b/components/mus/public/cpp/window_observer.h

index 52cc179e14e2f4b626a63e061fa6194d80d8410f..8e692ab151c04bb5ec4fee1606ab239e68d71043 100644

--- a/components/mus/public/cpp/window_observer.h

+++ b/components/mus/public/cpp/window_observer.h

@@ -97,6 +97,7 @@ class WindowObserver {

virtual void OnWindowDrawnChanged(Window* window) {}

protected:

+ WindowObserver() = default;

virtual ~WindowObserver() {}

};

« cc/trees/property_tree.h ('K') | « components/history/core/browser/history_service_observer.h ('k') | components/mus/ws/server_window_observer.h » ('j') | no next file with comments »