chrome/browser/extensions/install_observer.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/install_observer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/install_observer.h

diff --git a/chrome/browser/extensions/install_observer.h b/chrome/browser/extensions/install_observer.h

index 0185dd374212232dc27bc4a586cd6548e2d874d7..7a68d365f1ea3414c35018af9553d0961ad53d76 100644

--- a/chrome/browser/extensions/install_observer.h

+++ b/chrome/browser/extensions/install_observer.h

@@ -69,6 +69,7 @@ class InstallObserver {

virtual void OnShutdown() {}

protected:

+ InstallObserver() = default;

virtual ~InstallObserver() {}

};

« cc/trees/property_tree.h ('K') | « chrome/browser/extensions/api/bookmarks/bookmarks_api.cc ('k') | chrome/browser/pepper_flash_settings_manager.h » ('j') | no next file with comments »