Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: net/quic/quic_connection.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The entity that handles framing writes for a Quic client or server. 5 // The entity that handles framing writes for a Quic client or server.
6 // Each QuicSession will have a connection associated with it. 6 // Each QuicSession will have a connection associated with it.
7 // 7 //
8 // On the server side, the Dispatcher handles the raw reads, and hands off 8 // On the server side, the Dispatcher handles the raw reads, and hands off
9 // packets via ProcessUdpPacket for framing and processing. 9 // packets via ProcessUdpPacket for framing and processing.
10 // 10 //
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 virtual void OnResumeConnectionState( 241 virtual void OnResumeConnectionState(
242 const CachedNetworkParameters& cached_network_params) {} 242 const CachedNetworkParameters& cached_network_params) {}
243 243
244 // Called when the connection parameters are set from the supplied 244 // Called when the connection parameters are set from the supplied
245 // |config|. 245 // |config|.
246 virtual void OnSetFromConfig(const QuicConfig& config) {} 246 virtual void OnSetFromConfig(const QuicConfig& config) {}
247 247
248 // Called when RTT may have changed, including when an RTT is read from 248 // Called when RTT may have changed, including when an RTT is read from
249 // the config. 249 // the config.
250 virtual void OnRttChanged(QuicTime::Delta rtt) const {} 250 virtual void OnRttChanged(QuicTime::Delta rtt) const {}
251
252 protected:
253 QuicConnectionDebugVisitor() = default;
251 }; 254 };
252 255
253 class NET_EXPORT_PRIVATE QuicConnectionHelperInterface { 256 class NET_EXPORT_PRIVATE QuicConnectionHelperInterface {
254 public: 257 public:
255 virtual ~QuicConnectionHelperInterface() {} 258 virtual ~QuicConnectionHelperInterface() {}
256 259
257 // Returns a QuicClock to be used for all time related functions. 260 // Returns a QuicClock to be used for all time related functions.
258 virtual const QuicClock* GetClock() const = 0; 261 virtual const QuicClock* GetClock() const = 0;
259 262
260 // Returns a QuicRandom to be used for all random number related functions. 263 // Returns a QuicRandom to be used for all random number related functions.
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 986
984 // Whether a GoAway has been received. 987 // Whether a GoAway has been received.
985 bool goaway_received_; 988 bool goaway_received_;
986 989
987 DISALLOW_COPY_AND_ASSIGN(QuicConnection); 990 DISALLOW_COPY_AND_ASSIGN(QuicConnection);
988 }; 991 };
989 992
990 } // namespace net 993 } // namespace net
991 994
992 #endif // NET_QUIC_QUIC_CONNECTION_H_ 995 #endif // NET_QUIC_QUIC_CONNECTION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698