ui/app_list/app_list_model_observer.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/app_list_model_observer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/app_list_model_observer.h

diff --git a/ui/app_list/app_list_model_observer.h b/ui/app_list/app_list_model_observer.h

index 09cccc0e75531c8daf4925962e3677f114af5a5b..2b95532d45a489153cd7fbfc3b1aaef3c81c9989 100644

--- a/ui/app_list/app_list_model_observer.h

+++ b/ui/app_list/app_list_model_observer.h

@@ -40,6 +40,7 @@ class APP_LIST_EXPORT AppListModelObserver {

virtual void OnSearchEngineIsGoogleChanged(bool is_google) {}

protected:

+ AppListModelObserver() = default;

virtual ~AppListModelObserver() {}

};

« cc/trees/property_tree.h ('K') | « remoting/test/remote_connection_observer.h ('k') | ui/app_list/search_result_observer.h » ('j') | no next file with comments »