Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: content/public/browser/browser_main_parts.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_BROWSER_MAIN_PARTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_BROWSER_MAIN_PARTS_H_
6 #define CONTENT_PUBLIC_BROWSER_BROWSER_MAIN_PARTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_BROWSER_MAIN_PARTS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // "parts" (e.g., |EarlyInitialization()|) and provide platform-specific 42 // "parts" (e.g., |EarlyInitialization()|) and provide platform-specific
43 // implementations of your code (in a virtual method); do this if you need to 43 // implementations of your code (in a virtual method); do this if you need to
44 // provide different implementations across most/all platforms. 44 // provide different implementations across most/all platforms.
45 // - Unless your new code is just one or two lines, put it into a separate 45 // - Unless your new code is just one or two lines, put it into a separate
46 // method with a well-defined purpose. (Likewise, if you're adding to an 46 // method with a well-defined purpose. (Likewise, if you're adding to an
47 // existing chunk which makes it longer than one or two lines, please move 47 // existing chunk which makes it longer than one or two lines, please move
48 // the code out into a separate method.) 48 // the code out into a separate method.)
49 // 49 //
50 class CONTENT_EXPORT BrowserMainParts { 50 class CONTENT_EXPORT BrowserMainParts {
51 public: 51 public:
52 BrowserMainParts() {} 52 BrowserMainParts();
53 virtual ~BrowserMainParts() {} 53 virtual ~BrowserMainParts() {}
54 54
55 virtual void PreEarlyInitialization() {} 55 virtual void PreEarlyInitialization() {}
56 56
57 virtual void PostEarlyInitialization() {} 57 virtual void PostEarlyInitialization() {}
58 58
59 virtual void PreMainMessageLoopStart() {} 59 virtual void PreMainMessageLoopStart() {}
60 60
61 virtual void PostMainMessageLoopStart() {} 61 virtual void PostMainMessageLoopStart() {}
62 62
(...skipping 22 matching lines...) Expand all
85 virtual void PostMainMessageLoopRun() {} 85 virtual void PostMainMessageLoopRun() {}
86 86
87 // Called as the very last part of shutdown, after threads have been 87 // Called as the very last part of shutdown, after threads have been
88 // stopped and destroyed. 88 // stopped and destroyed.
89 virtual void PostDestroyThreads() {} 89 virtual void PostDestroyThreads() {}
90 }; 90 };
91 91
92 } // namespace content 92 } // namespace content
93 93
94 #endif // CONTENT_PUBLIC_BROWSER_BROWSER_MAIN_PARTS_H_ 94 #endif // CONTENT_PUBLIC_BROWSER_BROWSER_MAIN_PARTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698