Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 // Embedder API (or SPI) for participating in browser logic, to be implemented 136 // Embedder API (or SPI) for participating in browser logic, to be implemented
137 // by the client of the content browser. See ChromeContentBrowserClient for the 137 // by the client of the content browser. See ChromeContentBrowserClient for the
138 // principal implementation. The methods are assumed to be called on the UI 138 // principal implementation. The methods are assumed to be called on the UI
139 // thread unless otherwise specified. Use this "escape hatch" sparingly, to 139 // thread unless otherwise specified. Use this "escape hatch" sparingly, to
140 // avoid the embedder interface ballooning and becoming very specific to Chrome. 140 // avoid the embedder interface ballooning and becoming very specific to Chrome.
141 // (Often, the call out to the client can happen in a different part of the code 141 // (Often, the call out to the client can happen in a different part of the code
142 // that either already has a hook out to the embedder, or calls out to one of 142 // that either already has a hook out to the embedder, or calls out to one of
143 // the observer interfaces.) 143 // the observer interfaces.)
144 class CONTENT_EXPORT ContentBrowserClient { 144 class CONTENT_EXPORT ContentBrowserClient {
145 public: 145 public:
146 ContentBrowserClient();
146 virtual ~ContentBrowserClient() {} 147 virtual ~ContentBrowserClient() {}
147 148
148 // Allows the embedder to set any number of custom BrowserMainParts 149 // Allows the embedder to set any number of custom BrowserMainParts
149 // implementations for the browser startup code. See comments in 150 // implementations for the browser startup code. See comments in
150 // browser_main_parts.h. 151 // browser_main_parts.h.
151 virtual BrowserMainParts* CreateBrowserMainParts( 152 virtual BrowserMainParts* CreateBrowserMainParts(
152 const MainFunctionParams& parameters); 153 const MainFunctionParams& parameters);
153 154
154 // Allows the embedder to change the default behavior of 155 // Allows the embedder to change the default behavior of
155 // BrowserThread::PostAfterStartupTask to better match whatever 156 // BrowserThread::PostAfterStartupTask to better match whatever
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
754 // Allows an embedder to provide its own ExternalVideoSurfaceContainer 755 // Allows an embedder to provide its own ExternalVideoSurfaceContainer
755 // implementation. Return nullptr to disable external surface video. 756 // implementation. Return nullptr to disable external surface video.
756 virtual ExternalVideoSurfaceContainer* 757 virtual ExternalVideoSurfaceContainer*
757 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents); 758 OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
758 #endif 759 #endif
759 }; 760 };
760 761
761 } // namespace content 762 } // namespace content
762 763
763 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 764 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698