Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/macros.h"
8 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 10 #include "base/time/time.h"
10 #include "content/browser/frame_host/navigator_delegate.h" 11 #include "content/browser/frame_host/navigator_delegate.h"
11 #include "content/common/content_export.h" 12 #include "content/common/content_export.h"
12 #include "content/public/browser/navigation_controller.h" 13 #include "content/public/browser/navigation_controller.h"
13 #include "ui/base/window_open_disposition.h" 14 #include "ui/base/window_open_disposition.h"
14 15
15 class GURL; 16 class GURL;
16 struct FrameHostMsg_BeginNavigation_Params; 17 struct FrameHostMsg_BeginNavigation_Params;
17 struct FrameHostMsg_DidCommitProvisionalLoad_Params; 18 struct FrameHostMsg_DidCommitProvisionalLoad_Params;
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 base::TimeTicks timestamp, const GURL& url) {}; 182 base::TimeTicks timestamp, const GURL& url) {};
182 183
183 // Called to record the time it took to execute the before unload hook for the 184 // Called to record the time it took to execute the before unload hook for the
184 // current navigation. 185 // current navigation.
185 virtual void LogBeforeUnloadTime( 186 virtual void LogBeforeUnloadTime(
186 const base::TimeTicks& renderer_before_unload_start_time, 187 const base::TimeTicks& renderer_before_unload_start_time,
187 const base::TimeTicks& renderer_before_unload_end_time) {} 188 const base::TimeTicks& renderer_before_unload_end_time) {}
188 189
189 protected: 190 protected:
190 friend class base::RefCounted<Navigator>; 191 friend class base::RefCounted<Navigator>;
192 Navigator() = default;
191 virtual ~Navigator() {} 193 virtual ~Navigator() {}
194
195 private:
196 DISALLOW_COPY_AND_ASSIGN(Navigator);
192 }; 197 };
193 198
194 } // namespace content 199 } // namespace content
195 200
196 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 201 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698