Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: components/history/core/browser/history_service_observer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_service_observer.h
diff --git a/components/history/core/browser/history_service_observer.h b/components/history/core/browser/history_service_observer.h
index 4e4438735b165c81cfef7952ee7845a13f7d5983..a9d716bd123dcf499c2a100e79c6af9108cea865 100644
--- a/components/history/core/browser/history_service_observer.h
+++ b/components/history/core/browser/history_service_observer.h
@@ -15,7 +15,6 @@ class HistoryService;
class HistoryServiceObserver {
public:
- HistoryServiceObserver() {}
virtual ~HistoryServiceObserver() {}
// Called when user visits an URL.
@@ -73,6 +72,9 @@ class HistoryServiceObserver {
virtual void OnKeywordSearchTermDeleted(HistoryService* history_service,
URLID url_id) {}
+ protected:
+ HistoryServiceObserver() {}
+
private:
DISALLOW_COPY_AND_ASSIGN(HistoryServiceObserver);
};

Powered by Google App Engine
This is Rietveld 408576698