extensions/browser/api/socket/socket_api.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/socket_api.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/socket/socket_api.h

diff --git a/extensions/browser/api/socket/socket_api.h b/extensions/browser/api/socket/socket_api.h

index 9c26c258b49677d1f10369277c33e1e98c7a3415..23beb844eeb3f1f1ac04d24d6cc1709cd1893cfc 100644

--- a/extensions/browser/api/socket/socket_api.h

+++ b/extensions/browser/api/socket/socket_api.h

@@ -240,6 +240,8 @@ class SocketBindFunction : public SocketAsyncApiFunction {

public:

DECLARE_EXTENSION_FUNCTION("socket.bind", SOCKET_BIND)

+ SocketBindFunction();

protected:

~SocketBindFunction() override {}

« cc/trees/property_tree.h ('K') | « device/nfc/nfc_adapter.h ('k') | extensions/browser/api/socket/socket_api.cc » ('j') | no next file with comments »