google_apis/gaia/gaia_auth_consumer.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_auth_consumer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gaia/gaia_auth_consumer.h

diff --git a/google_apis/gaia/gaia_auth_consumer.h b/google_apis/gaia/gaia_auth_consumer.h

index b8f70df621b73f07d9ac30167d2b6b4b28477561..e3310a6d607bd76ecda0b7a9593c4ec0f37e1296 100644

--- a/google_apis/gaia/gaia_auth_consumer.h

+++ b/google_apis/gaia/gaia_auth_consumer.h

@@ -98,6 +98,9 @@ class GaiaAuthConsumer {

virtual void OnGetTokenResponseSuccess(const ClientOAuthResult& result) {}

virtual void OnGetTokenResponseError(const GoogleServiceAuthError& error) {}

+ protected:

+ GaiaAuthConsumer() = default;

};

#endif // GOOGLE_APIS_GAIA_GAIA_AUTH_CONSUMER_H_

« cc/trees/property_tree.h ('K') | « extensions/renderer/dispatcher_delegate.cc ('k') | ipc/ipc_test_channel_listener.h » ('j') | no next file with comments »