Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: components/translate/content/browser/browser_cld_data_provider.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TRANSLATE_CONTENT_BROWSER_BROWSER_CLD_DATA_PROVIDER_H_ 5 #ifndef COMPONENTS_TRANSLATE_CONTENT_BROWSER_BROWSER_CLD_DATA_PROVIDER_H_
6 #define COMPONENTS_TRANSLATE_CONTENT_BROWSER_BROWSER_CLD_DATA_PROVIDER_H_ 6 #define COMPONENTS_TRANSLATE_CONTENT_BROWSER_BROWSER_CLD_DATA_PROVIDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 13 matching lines...) Expand all
24 // 24 //
25 // The glue between them is typically a pair of request/response IPC messages 25 // The glue between them is typically a pair of request/response IPC messages
26 // using the "CldDataProviderMsgStart" IPCMessageStart enumerated constant from 26 // using the "CldDataProviderMsgStart" IPCMessageStart enumerated constant from
27 // ipc_message_start.h 27 // ipc_message_start.h
28 // 28 //
29 // In general, instances of this class should be obtained by using the 29 // In general, instances of this class should be obtained by using the
30 // BrowserCldDataProviderFactory::CreateBrowserCldProvider(...). For more 30 // BrowserCldDataProviderFactory::CreateBrowserCldProvider(...). For more
31 // information, see browser_cld_data_provider_factory.h. 31 // information, see browser_cld_data_provider_factory.h.
32 class BrowserCldDataProvider : public IPC::Listener { 32 class BrowserCldDataProvider : public IPC::Listener {
33 public: 33 public:
34 BrowserCldDataProvider() {} 34 BrowserCldDataProvider();
35 ~BrowserCldDataProvider() override {} 35 ~BrowserCldDataProvider() override {}
36 36
37 // IPC::Listener implementation: 37 // IPC::Listener implementation:
38 // If the specified message is a request for CLD data, invokes 38 // If the specified message is a request for CLD data, invokes
39 // OnCldDataRequest() and returns true. In all other cases, this method does 39 // OnCldDataRequest() and returns true. In all other cases, this method does
40 // nothing. This method is defined as virtual in order to force the 40 // nothing. This method is defined as virtual in order to force the
41 // implementation to define the specific IPC message(s) that it handles. 41 // implementation to define the specific IPC message(s) that it handles.
42 // The default implementation does nothing and returns false. 42 // The default implementation does nothing and returns false.
43 bool OnMessageReceived(const IPC::Message&) override; 43 bool OnMessageReceived(const IPC::Message&) override;
44 44
(...skipping 14 matching lines...) Expand all
59 // The default implementation does nothing. 59 // The default implementation does nothing.
60 virtual void SendCldDataResponse() {} 60 virtual void SendCldDataResponse() {}
61 61
62 private: 62 private:
63 DISALLOW_COPY_AND_ASSIGN(BrowserCldDataProvider); 63 DISALLOW_COPY_AND_ASSIGN(BrowserCldDataProvider);
64 }; 64 };
65 65
66 } // namespace translate 66 } // namespace translate
67 67
68 #endif // COMPONENTS_TRANSLATE_CONTENT_BROWSER_BROWSER_CLD_DATA_PROVIDER_H_ 68 #endif // COMPONENTS_TRANSLATE_CONTENT_BROWSER_BROWSER_CLD_DATA_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698