Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: net/quic/test_tools/quic_test_utils.cc

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/test_tools/quic_test_utils.h" 5 #include "net/quic/test_tools/quic_test_utils.h"
6 6
7 #include "base/sha1.h" 7 #include "base/sha1.h"
8 #include "base/stl_util.h" 8 #include "base/stl_util.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "net/quic/crypto/crypto_framer.h" 10 #include "net/quic/crypto/crypto_framer.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 135
136 ON_CALL(*this, OnConnectionCloseFrame(_)) 136 ON_CALL(*this, OnConnectionCloseFrame(_))
137 .WillByDefault(testing::Return(true)); 137 .WillByDefault(testing::Return(true));
138 138
139 ON_CALL(*this, OnGoAwayFrame(_)) 139 ON_CALL(*this, OnGoAwayFrame(_))
140 .WillByDefault(testing::Return(true)); 140 .WillByDefault(testing::Return(true));
141 } 141 }
142 142
143 MockFramerVisitor::~MockFramerVisitor() {} 143 MockFramerVisitor::~MockFramerVisitor() {}
144 144
145 NoOpFramerVisitor::NoOpFramerVisitor() = default;
146
145 bool NoOpFramerVisitor::OnProtocolVersionMismatch(QuicVersion version) { 147 bool NoOpFramerVisitor::OnProtocolVersionMismatch(QuicVersion version) {
146 return false; 148 return false;
147 } 149 }
148 150
149 bool NoOpFramerVisitor::OnUnauthenticatedPublicHeader( 151 bool NoOpFramerVisitor::OnUnauthenticatedPublicHeader(
150 const QuicPacketPublicHeader& header) { 152 const QuicPacketPublicHeader& header) {
151 return true; 153 return true;
152 } 154 }
153 155
154 bool NoOpFramerVisitor::OnUnauthenticatedHeader( 156 bool NoOpFramerVisitor::OnUnauthenticatedHeader(
(...skipping 658 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 // strike register worries that we've just overflowed a uint32 time. 815 // strike register worries that we've just overflowed a uint32 time.
814 (*server_connection)->AdvanceTime(connection_start_time); 816 (*server_connection)->AdvanceTime(connection_start_time);
815 } 817 }
816 818
817 QuicStreamId QuicClientDataStreamId(int i) { 819 QuicStreamId QuicClientDataStreamId(int i) {
818 return kClientDataStreamId1 + 2 * i; 820 return kClientDataStreamId1 + 2 * i;
819 } 821 }
820 822
821 } // namespace test 823 } // namespace test
822 } // namespace net 824 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698