Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
index 7096759a46d8fbd5d9a129f67288912660656eb0..a931c57e13e3eadef874a273636775dcb84d203f 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
@@ -416,6 +416,8 @@ void BookmarksAPI::OnListenerAdded(const EventListenerInfo& details) {
EventRouter::Get(browser_context_)->UnregisterObserver(this);
}
+BookmarksGetFunction::BookmarksGetFunction() = default;
+
bool BookmarksGetFunction::RunOnReady() {
scoped_ptr<bookmarks::Get::Params> params(
bookmarks::Get::Params::Create(*args_));
@@ -445,6 +447,8 @@ bool BookmarksGetFunction::RunOnReady() {
return true;
}
+BookmarksGetChildrenFunction::BookmarksGetChildrenFunction() = default;
+
bool BookmarksGetChildrenFunction::RunOnReady() {
scoped_ptr<bookmarks::GetChildren::Params> params(
bookmarks::GetChildren::Params::Create(*args_));
@@ -466,6 +470,8 @@ bool BookmarksGetChildrenFunction::RunOnReady() {
return true;
}
+BookmarksGetRecentFunction::BookmarksGetRecentFunction() = default;
+
bool BookmarksGetRecentFunction::RunOnReady() {
scoped_ptr<bookmarks::GetRecent::Params> params(
bookmarks::GetRecent::Params::Create(*args_));
@@ -491,6 +497,8 @@ bool BookmarksGetRecentFunction::RunOnReady() {
return true;
}
+BookmarksGetTreeFunction::BookmarksGetTreeFunction() = default;
+
bool BookmarksGetTreeFunction::RunOnReady() {
std::vector<linked_ptr<BookmarkTreeNode> > nodes;
const BookmarkNode* node =
@@ -501,6 +509,8 @@ bool BookmarksGetTreeFunction::RunOnReady() {
return true;
}
+BookmarksGetSubTreeFunction::BookmarksGetSubTreeFunction() = default;
+
bool BookmarksGetSubTreeFunction::RunOnReady() {
scoped_ptr<bookmarks::GetSubTree::Params> params(
bookmarks::GetSubTree::Params::Create(*args_));
@@ -517,6 +527,8 @@ bool BookmarksGetSubTreeFunction::RunOnReady() {
return true;
}
+BookmarksSearchFunction::BookmarksSearchFunction() = default;
+
bool BookmarksSearchFunction::RunOnReady() {
scoped_ptr<bookmarks::Search::Params> params(
bookmarks::Search::Params::Create(*args_));
@@ -567,6 +579,8 @@ bool BookmarksSearchFunction::RunOnReady() {
return true;
}
+BookmarksRemoveFunction::BookmarksRemoveFunction() = default;
+
// static
bool BookmarksRemoveFunction::ExtractIds(const base::ListValue* args,
std::list<int64>* ids,
@@ -606,6 +620,10 @@ bool BookmarksRemoveFunction::RunOnReady() {
return true;
}
+BookmarksRemoveTreeFunction::BookmarksRemoveTreeFunction() = default;
+
+BookmarksCreateFunction::BookmarksCreateFunction() = default;
+
bool BookmarksCreateFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -626,6 +644,8 @@ bool BookmarksCreateFunction::RunOnReady() {
return true;
}
+BookmarksMoveFunction::BookmarksMoveFunction() = default;
+
// static
bool BookmarksMoveFunction::ExtractIds(const base::ListValue* args,
std::list<int64>* ids,
@@ -687,6 +707,8 @@ bool BookmarksMoveFunction::RunOnReady() {
return true;
}
+BookmarksUpdateFunction::BookmarksUpdateFunction() = default;
+
// static
bool BookmarksUpdateFunction::ExtractIds(const base::ListValue* args,
std::list<int64>* ids,
@@ -822,6 +844,8 @@ void BookmarksIOFunction::MultiFilesSelected(
NOTREACHED() << "Should not be able to select multiple files";
}
+BookmarksImportFunction::BookmarksImportFunction() = default;
+
bool BookmarksImportFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -847,6 +871,8 @@ void BookmarksImportFunction::FileSelected(const base::FilePath& path,
Release(); // Balanced in BookmarksIOFunction::SelectFile()
}
+BookmarksExportFunction::BookmarksExportFunction() = default;
+
bool BookmarksExportFunction::RunOnReady() {
SelectFile(ui::SelectFileDialog::SELECT_SAVEAS_FILE);
return true;

Powered by Google App Engine
This is Rietveld 408576698