Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/pepper_flash_settings_manager.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PEPPER_FLASH_SETTINGS_MANAGER_H_ 5 #ifndef CHROME_BROWSER_PEPPER_FLASH_SETTINGS_MANAGER_H_
6 #define CHROME_BROWSER_PEPPER_FLASH_SETTINGS_MANAGER_H_ 6 #define CHROME_BROWSER_PEPPER_FLASH_SETTINGS_MANAGER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 bool success) {} 43 bool success) {}
44 44
45 virtual void OnSetSitePermissionCompleted(uint32 request_id, 45 virtual void OnSetSitePermissionCompleted(uint32 request_id,
46 bool success) {} 46 bool success) {}
47 47
48 virtual void OnGetSitesWithDataCompleted( 48 virtual void OnGetSitesWithDataCompleted(
49 uint32 request_id, 49 uint32 request_id,
50 const std::vector<std::string>& sites) {} 50 const std::vector<std::string>& sites) {}
51 51
52 virtual void OnClearSiteDataCompleted(uint32 request_id, bool success) {} 52 virtual void OnClearSiteDataCompleted(uint32 request_id, bool success) {}
53
54 protected:
55 Client() = default;
53 }; 56 };
54 57
55 // |client| must outlive this object. It is guaranteed that |client| won't 58 // |client| must outlive this object. It is guaranteed that |client| won't
56 // receive any notifications after this object goes away. 59 // receive any notifications after this object goes away.
57 PepperFlashSettingsManager(Client* client, 60 PepperFlashSettingsManager(Client* client,
58 content::BrowserContext* browser_context); 61 content::BrowserContext* browser_context);
59 ~PepperFlashSettingsManager(); 62 ~PepperFlashSettingsManager();
60 63
61 // |plugin_info| will be updated if it is not NULL and the method returns 64 // |plugin_info| will be updated if it is not NULL and the method returns
62 // true. 65 // true.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 scoped_refptr<Core> core_; 130 scoped_refptr<Core> core_;
128 131
129 uint32 next_request_id_; 132 uint32 next_request_id_;
130 133
131 base::WeakPtrFactory<PepperFlashSettingsManager> weak_ptr_factory_; 134 base::WeakPtrFactory<PepperFlashSettingsManager> weak_ptr_factory_;
132 135
133 DISALLOW_COPY_AND_ASSIGN(PepperFlashSettingsManager); 136 DISALLOW_COPY_AND_ASSIGN(PepperFlashSettingsManager);
134 }; 137 };
135 138
136 #endif // CHROME_BROWSER_PEPPER_FLASH_SETTINGS_MANAGER_H_ 139 #endif // CHROME_BROWSER_PEPPER_FLASH_SETTINGS_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698